From bf9a3843248cae81e1223bc203bb6f4b397207df Mon Sep 17 00:00:00 2001 From: Clement Ho Date: Mon, 6 Mar 2017 21:03:35 -0600 Subject: Test bare bones double click --- .../filtered_search_visual_tokens.js.es6 | 49 +++++++++++----------- .../issues/filtered_search/visual_tokens_spec.rb | 2 +- 2 files changed, 26 insertions(+), 25 deletions(-) diff --git a/app/assets/javascripts/filtered_search/filtered_search_visual_tokens.js.es6 b/app/assets/javascripts/filtered_search/filtered_search_visual_tokens.js.es6 index 78b245726ee..b73d7254fb8 100644 --- a/app/assets/javascripts/filtered_search/filtered_search_visual_tokens.js.es6 +++ b/app/assets/javascripts/filtered_search/filtered_search_visual_tokens.js.es6 @@ -147,30 +147,31 @@ class FilteredSearchVisualTokens { static editToken(token) { const input = document.querySelector('.filtered-search'); - FilteredSearchVisualTokens.tokenizeInput(); - - // Replace token with input field - const tokenContainer = token.parentElement; - const inputLi = input.parentElement; - tokenContainer.replaceChild(inputLi, token); - - const name = token.querySelector('.name'); - const value = token.querySelector('.value'); - - if (token.classList.contains('filtered-search-token')) { - FilteredSearchVisualTokens.addFilterVisualToken(name.innerText); - input.value = value.innerText; - } else { - // token is a search term - input.value = name.innerText; - } - - // Opens dropdown - const inputEvent = new Event('input'); - input.dispatchEvent(inputEvent); - - // Adds cursor to input - input.focus(); + input.value = 'enhancement'; + // FilteredSearchVisualTokens.tokenizeInput(); + + // // Replace token with input field + // const tokenContainer = token.parentElement; + // const inputLi = input.parentElement; + // tokenContainer.replaceChild(inputLi, token); + + // const name = token.querySelector('.name'); + // const value = token.querySelector('.value'); + + // if (token.classList.contains('filtered-search-token')) { + // FilteredSearchVisualTokens.addFilterVisualToken(name.innerText); + // input.value = value.innerText; + // } else { + // // token is a search term + // input.value = name.innerText; + // } + + // // Opens dropdown + // const inputEvent = new Event('input'); + // input.dispatchEvent(inputEvent); + + // // Adds cursor to input + // input.focus(); } static moveInputToTheRight() { diff --git a/spec/features/issues/filtered_search/visual_tokens_spec.rb b/spec/features/issues/filtered_search/visual_tokens_spec.rb index 93b0bf04fae..a6ed1dfa1c6 100644 --- a/spec/features/issues/filtered_search/visual_tokens_spec.rb +++ b/spec/features/issues/filtered_search/visual_tokens_spec.rb @@ -8,7 +8,7 @@ describe 'Visual tokens', js: true, feature: true do let!(:user_rock) { create(:user, name: 'The Rock', username: 'rock') } let!(:milestone_nine) { create(:milestone, title: '9.0', project: project) } let!(:milestone_ten) { create(:milestone, title: '10.0', project: project) } - let!(:label) { create(:label, project: project, title: 'abc') } + let!(:label) { create(:label, project: project, title: 'enhancement') } let!(:cc_label) { create(:label, project: project, title: 'Community Contribution') } let(:filtered_search) { find('.filtered-search') } -- cgit v1.2.1