From c1cf0f2992bc1db77d7374baea835375592c9fef Mon Sep 17 00:00:00 2001
From: Marcel van Remmerden <mvanremmerden@gitlab.com>
Date: Fri, 31 May 2019 15:36:09 +0000
Subject: Resize collapse icon to profile picture size

---
 .../diffs/components/diff_gutter_avatars.vue       |  1 -
 app/assets/stylesheets/framework/buttons.scss      |  4 ++--
 app/assets/stylesheets/framework/mixins.scss       |  5 +++++
 app/assets/stylesheets/pages/diff.scss             | 22 +++++++++++++---------
 app/assets/stylesheets/pages/notes.scss            | 10 ++++------
 ...ge-request-diff-larger-than-profile-picture.yml |  5 +++++
 6 files changed, 29 insertions(+), 18 deletions(-)
 create mode 100644 changelogs/unreleased/61988-collapse-icon-on-merge-request-diff-larger-than-profile-picture.yml

diff --git a/app/assets/javascripts/diffs/components/diff_gutter_avatars.vue b/app/assets/javascripts/diffs/components/diff_gutter_avatars.vue
index 0c0a0faa59d..7cf3d90d468 100644
--- a/app/assets/javascripts/diffs/components/diff_gutter_avatars.vue
+++ b/app/assets/javascripts/diffs/components/diff_gutter_avatars.vue
@@ -86,7 +86,6 @@ export default {
         :key="note.id"
         :img-src="note.author.avatar_url"
         :tooltip-text="getTooltipText(note)"
-        :size="19"
         class="diff-comment-avatar js-diff-comment-avatar"
         @click.native="toggleDiscussions"
       />
diff --git a/app/assets/stylesheets/framework/buttons.scss b/app/assets/stylesheets/framework/buttons.scss
index b85abfd9c14..97a763671ba 100644
--- a/app/assets/stylesheets/framework/buttons.scss
+++ b/app/assets/stylesheets/framework/buttons.scss
@@ -1,12 +1,12 @@
 @mixin btn-comment-icon {
   border-radius: 50%;
   background: $white-light;
-  padding: 1px 5px;
+  padding: 1px;
   font-size: 12px;
   color: $blue-500;
+  border: 1px solid $blue-500;
   width: 24px;
   height: 24px;
-  border: 1px solid $blue-500;
 
   &:hover,
   &.inverted {
diff --git a/app/assets/stylesheets/framework/mixins.scss b/app/assets/stylesheets/framework/mixins.scss
index 18671f7c4d8..df40149f0a6 100644
--- a/app/assets/stylesheets/framework/mixins.scss
+++ b/app/assets/stylesheets/framework/mixins.scss
@@ -385,3 +385,8 @@
   height: $size;
   margin-right: $margin-right;
 }
+
+@mixin code-icon-size() {
+  width: $gl-font-size * $code-line-height * 0.9;
+  height: $gl-font-size * $code-line-height * 0.9;
+}
diff --git a/app/assets/stylesheets/pages/diff.scss b/app/assets/stylesheets/pages/diff.scss
index b3a634e23a3..4a648a5d3b6 100644
--- a/app/assets/stylesheets/pages/diff.scss
+++ b/app/assets/stylesheets/pages/diff.scss
@@ -615,10 +615,9 @@ table.code {
 
 .diff-comment-avatar-holders {
   position: absolute;
-  height: 19px;
-  width: 19px;
-  margin-left: -15px;
+  margin-left: -$gl-padding;
   z-index: 100;
+  @include code-icon-size();
 
   &:hover {
     .diff-comment-avatar,
@@ -652,26 +651,28 @@ table.code {
 .diff-comments-more-count {
   position: absolute;
   left: 0;
-  width: 19px;
-  height: 19px;
   margin-right: 0;
   border-color: $white-light;
   cursor: pointer;
   transition: all 0.1s ease-out;
+  @include code-icon-size();
 
   @for $i from 1 through 4 {
     &:nth-child(#{$i}) {
       z-index: (4 - $i);
     }
   }
+
+  .avatar {
+    @include code-icon-size();
+  }
 }
 
 .diff-comments-more-count {
-  width: 19px;
-  min-width: 19px;
   padding-left: 0;
   padding-right: 0;
   overflow: hidden;
+  @include code-icon-size();
 }
 
 .diff-comments-more-count,
@@ -680,12 +681,15 @@ table.code {
 }
 
 .diff-notes-collapse {
-  width: 24px;
-  height: 24px;
+  border: 0;
   border-radius: 50%;
   padding: 0;
   transition: transform 0.1s ease-out;
   z-index: 100;
+  display: flex;
+  justify-content: center;
+  align-items: center;
+  @include code-icon-size();
 
   .collapse-icon {
     height: 50%;
diff --git a/app/assets/stylesheets/pages/notes.scss b/app/assets/stylesheets/pages/notes.scss
index 170432a9e62..32477c20db6 100644
--- a/app/assets/stylesheets/pages/notes.scss
+++ b/app/assets/stylesheets/pages/notes.scss
@@ -437,7 +437,9 @@ $note-form-margin-left: 72px;
 .diff-file {
   .is-over {
     .add-diff-note {
-      display: inline-block;
+      display: inline-flex;
+      justify-content: center;
+      align-items: center;
     }
   }
 
@@ -741,7 +743,7 @@ $note-form-margin-left: 72px;
 .add-diff-note {
   @include btn-comment-icon;
   opacity: 0;
-  margin-left: -50px;
+  margin-left: -52px;
   position: absolute;
   top: 50%;
   transform: translateY(-50%);
@@ -900,10 +902,6 @@ $note-form-margin-left: 72px;
   .diff-comment-form {
     display: block;
   }
-
-  .add-diff-note svg {
-    margin-top: 4px;
-  }
 }
 
 .discussion-filter-container {
diff --git a/changelogs/unreleased/61988-collapse-icon-on-merge-request-diff-larger-than-profile-picture.yml b/changelogs/unreleased/61988-collapse-icon-on-merge-request-diff-larger-than-profile-picture.yml
new file mode 100644
index 00000000000..46d3f439a44
--- /dev/null
+++ b/changelogs/unreleased/61988-collapse-icon-on-merge-request-diff-larger-than-profile-picture.yml
@@ -0,0 +1,5 @@
+---
+title: Change collapse icon size to size of profile picture 
+merge_request: 28512
+author: Marcel van Remmerden
+type: other
-- 
cgit v1.2.1