From d1dd115356a06fd20e8b9293cd645bb064b7c56a Mon Sep 17 00:00:00 2001 From: Zeger-Jan van de Weg Date: Thu, 5 Oct 2017 15:14:44 +0200 Subject: Update test to use the new API --- spec/models/ci/artifact_blob_spec.rb | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/spec/models/ci/artifact_blob_spec.rb b/spec/models/ci/artifact_blob_spec.rb index 81500fce6f9..d5ba088af53 100644 --- a/spec/models/ci/artifact_blob_spec.rb +++ b/spec/models/ci/artifact_blob_spec.rb @@ -1,7 +1,8 @@ require 'spec_helper' describe Ci::ArtifactBlob do - set(:build) { create(:ci_build, :artifacts) } + set(:project) { create(:project, :public) } + set(:build) { create(:ci_build, :artifacts, project: project) } let(:entry) { build.artifacts_metadata_entry('other_artifacts_0.1.2/another-subdirectory/banana_sample.gif') } subject { described_class.new(entry) } @@ -74,12 +75,18 @@ describe Ci::ArtifactBlob do allow(Gitlab.config.pages).to receive(:artifacts_server).and_return(true) end - it { is_expected.not_to be_external_link } + context 'gif extensions' do + it 'returns false' do + expect(subject.external_link?(build)).to be false + end + end context 'txt extensions' do let(:entry) { build.artifacts_metadata_entry('other_artifacts_0.1.2/doc_sample.txt') } - it { is_expected.to be_external_link } + it 'returns true' do + expect(subject.external_link?(build)).to be true + end end end end -- cgit v1.2.1