From d9251f2ea047d359d1d7d4799d1ba84da5896f64 Mon Sep 17 00:00:00 2001 From: Dylan Griffith Date: Sun, 27 May 2018 13:43:05 +0200 Subject: Fix specs api/runners_spec.rb, api/v3/runners_spec.rb update_build_queue_service_spec.rb --- spec/requests/api/runners_spec.rb | 2 +- spec/services/ci/update_build_queue_service_spec.rb | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/spec/requests/api/runners_spec.rb b/spec/requests/api/runners_spec.rb index 41cd93ac672..4dfc3b8cfc4 100644 --- a/spec/requests/api/runners_spec.rb +++ b/spec/requests/api/runners_spec.rb @@ -13,7 +13,7 @@ describe API::Runners do let!(:shared_runner) { create(:ci_runner, :instance, description: 'Shared runner') } let!(:project_runner) { create(:ci_runner, :project, description: 'Project runner', projects: [project]) } - let!(:two_projects_runner) { create(:ci_runner, :project, description: 'Two projects runner', projects: [project, project2]) + let!(:two_projects_runner) { create(:ci_runner, :project, description: 'Two projects runner', projects: [project, project2]) } let!(:group_runner) { create(:ci_runner, :group, description: 'Group runner', groups: [group]) } before do diff --git a/spec/services/ci/update_build_queue_service_spec.rb b/spec/services/ci/update_build_queue_service_spec.rb index e4b92956e48..ca0c6be5da6 100644 --- a/spec/services/ci/update_build_queue_service_spec.rb +++ b/spec/services/ci/update_build_queue_service_spec.rb @@ -15,6 +15,9 @@ describe Ci::UpdateBuildQueueService do end context 'when there is no runner that can pick build' do + let(:another_project) { create(:project) } + let(:runner) { create(:ci_runner, :project, projects: [another_project]) } + it 'does not tick runner queue value' do expect { subject.execute(build) }.not_to change { runner.ensure_runner_queue_value } end -- cgit v1.2.1