From dbb8644c240615f8a264b3b0f49fa9936d69fd3d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matija=20=C4=8Cupi=C4=87?= <matteeyah@gmail.com>
Date: Tue, 5 Dec 2017 23:40:24 +0100
Subject: Refactor Clusters::CreateService spec

---
 spec/services/clusters/create_service_spec.rb | 120 +++++++++++++-------------
 1 file changed, 62 insertions(+), 58 deletions(-)

diff --git a/spec/services/clusters/create_service_spec.rb b/spec/services/clusters/create_service_spec.rb
index d758bf6beb2..af535a52638 100644
--- a/spec/services/clusters/create_service_spec.rb
+++ b/spec/services/clusters/create_service_spec.rb
@@ -4,86 +4,90 @@ describe Clusters::CreateService do
   let(:access_token) { 'xxx' }
   let(:project) { create(:project) }
   let(:user) { create(:user) }
-  let(:result) { described_class.new(project, user, params).execute(access_token) }
 
-  context 'when provider is gcp' do
-    context 'when project has no clusters' do
-      context 'when correct params' do
-        let(:params) do
-          {
-            name: 'test-cluster',
-            provider_type: :gcp,
-            provider_gcp_attributes: {
-              gcp_project_id: 'gcp-project',
-              zone: 'us-central1-a',
-              num_nodes: 1,
-              machine_type: 'machine_type-a'
-            }
-          }
-        end
-
-        it 'creates a cluster object and performs a worker' do
-          expect(ClusterProvisionWorker).to receive(:perform_async)
-
-          expect { result }
-            .to change { Clusters::Cluster.count }.by(1)
-            .and change { Clusters::Providers::Gcp.count }.by(1)
+  subject { described_class.new(project, user, params).execute(access_token) }
 
-          expect(result.name).to eq('test-cluster')
-          expect(result.user).to eq(user)
-          expect(result.project).to eq(project)
-          expect(result.provider.gcp_project_id).to eq('gcp-project')
-          expect(result.provider.zone).to eq('us-central1-a')
-          expect(result.provider.num_nodes).to eq(1)
-          expect(result.provider.machine_type).to eq('machine_type-a')
-          expect(result.provider.access_token).to eq(access_token)
-          expect(result.platform).to be_nil
-        end
-      end
-
-      context 'when invalid params' do
-        let(:params) do
-          {
-            name: 'test-cluster',
-            provider_type: :gcp,
-            provider_gcp_attributes: {
-              gcp_project_id: '!!!!!!!',
-              zone: 'us-central1-a',
-              num_nodes: 1,
-              machine_type: 'machine_type-a'
-            }
+  context 'when provider is gcp' do
+    shared_context 'valid params' do
+      let(:params) do
+        {
+          name: 'test-cluster',
+          provider_type: :gcp,
+          provider_gcp_attributes: {
+            gcp_project_id: 'gcp-project',
+            zone: 'us-central1-a',
+            num_nodes: 1,
+            machine_type: 'machine_type-a'
           }
-        end
-
-        it 'returns an error' do
-          expect(ClusterProvisionWorker).not_to receive(:perform_async)
-          expect { result }.to change { Clusters::Cluster.count }.by(0)
-          expect(result.errors[:"provider_gcp.gcp_project_id"]).to be_present
-        end
+        }
       end
     end
 
-    context 'when project has a cluster' do
+    shared_context 'invalid params' do
       let(:params) do
         {
           name: 'test-cluster',
           provider_type: :gcp,
           provider_gcp_attributes: {
-            gcp_project_id: 'gcp-project',
+            gcp_project_id: '!!!!!!!',
             zone: 'us-central1-a',
             num_nodes: 1,
             machine_type: 'machine_type-a'
           }
         }
       end
+    end
+
+    shared_examples 'create cluster' do
+      it 'creates a cluster object and performs a worker' do
+        expect(ClusterProvisionWorker).to receive(:perform_async)
+
+        expect { subject }
+          .to change { Clusters::Cluster.count }.by(1)
+          .and change { Clusters::Providers::Gcp.count }.by(1)
+
+        expect(subject.name).to eq('test-cluster')
+        expect(subject.user).to eq(user)
+        expect(subject.project).to eq(project)
+        expect(subject.provider.gcp_project_id).to eq('gcp-project')
+        expect(subject.provider.zone).to eq('us-central1-a')
+        expect(subject.provider.num_nodes).to eq(1)
+        expect(subject.provider.machine_type).to eq('machine_type-a')
+        expect(subject.provider.access_token).to eq(access_token)
+        expect(subject.platform).to be_nil
+      end
+    end
+
+    shared_examples 'error' do
+      it 'returns an error' do
+        expect(ClusterProvisionWorker).not_to receive(:perform_async)
+        expect { subject }.to change { Clusters::Cluster.count }.by(0)
+        expect(subject.errors[:"provider_gcp.gcp_project_id"]).to be_present
+      end
+    end
+
+
+    context 'when project has no clusters' do
+      context 'when correct params' do
+        include_context 'valid params'
+
+        include_examples 'create cluster'
+      end
 
-      before do
-        Clusters::Cluster.create(params.merge(user: user, projects: [project]))
+      context 'when invalid params' do
+        include_context 'invalid params'
+
+        include_examples 'error'
       end
+    end
+
+    context 'when project has a cluster' do
+      include_context 'valid params'
+      let!(:cluster) { create(:cluster, :provided_by_gcp, projects: [project]) }
 
       it 'does not create a cluster' do
         expect(ClusterProvisionWorker).not_to receive(:perform_async)
-        expect { result }.to raise_error(Exception).and change { Clusters::Cluster.count }.by(0)
+        expect { subject }.to raise_error(ArgumentError).and change { Clusters::Cluster.count }.by(0)
       end
     end
   end
-- 
cgit v1.2.1