From e2a2ba6810d21fd1a54f4c25b135fdc2039f9030 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= Date: Thu, 27 Sep 2018 12:14:09 +0200 Subject: Fix a sanity framework test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On first load, the login page displays the "Change your password" tab, not the "Sign in" tab. We now assert on the presence of a text that's always on this page. Note that in EE, since a license is added in the `#perform_before_hooks` method, the password is changed so that when we visit the login page, the "Sign in" tab is displayed as expected. That's why only the CE job failed to pass in https://gitlab.com/gitlab-org/gitlab-qa/pipelines/31060920. Signed-off-by: Rémy Coutable --- qa/qa/specs/features/sanity/framework_spec.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qa/qa/specs/features/sanity/framework_spec.rb b/qa/qa/specs/features/sanity/framework_spec.rb index ee9d068eb3a..aae0f0ade71 100644 --- a/qa/qa/specs/features/sanity/framework_spec.rb +++ b/qa/qa/specs/features/sanity/framework_spec.rb @@ -6,9 +6,7 @@ module QA it 'succeeds' do Runtime::Browser.visit(:gitlab, Page::Main::Login) - Page::Main::Login.perform do |main_login| - expect(main_login.sign_in_tab?).to be(true) - end + expect(page).to have_text('Open source software to collaborate on code') end end -- cgit v1.2.1