From e7f744f0350ea87749683817205232b5ba047ffc Mon Sep 17 00:00:00 2001 From: Andrew Patterson Date: Tue, 7 Mar 2023 16:44:33 -0700 Subject: Gem update doc guidelines now require all platform builds Documentation changed for gem update guidelines now require builds on all supported platforms instead of review by C language expert. --- doc/development/gemfile.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/development/gemfile.md b/doc/development/gemfile.md index bfe8b7c5205..6d50dc0d8fa 100644 --- a/doc/development/gemfile.md +++ b/doc/development/gemfile.md @@ -60,6 +60,8 @@ This means that new dependencies should, at a minimum, meet the following criter - There are no issues open that we know may impact the availability or performance of GitLab. - The project is tested using some form of test automation. The test suite must be passing using the Ruby version currently used by GitLab. +- CI builds for all supported platforms must succeed using the new dependency. See + [Building a package for testing](build_test_package.md#building-a-package-for-testing) for details. - If the project uses a C extension, consider requesting an additional review from a C or MRI domain expert. C extensions can greatly impact GitLab stability and performance. -- cgit v1.2.1