From babc1d023ee1352bdcc0444a5575774bd693ffc8 Mon Sep 17 00:00:00 2001 From: Achilleas Pipinellis Date: Mon, 25 Sep 2017 10:00:37 +0200 Subject: Change mode to 644 for all md and png files --- doc/university/training/gitlab_flow.md | 0 doc/university/training/index.md | 0 doc/university/training/topics/additional_resources.md | 0 doc/university/training/topics/agile_git.md | 0 doc/university/training/topics/bisect.md | 0 doc/university/training/topics/cherry_picking.md | 0 doc/university/training/topics/env_setup.md | 0 doc/university/training/topics/explore_gitlab.md | 0 doc/university/training/topics/feature_branching.md | 0 doc/university/training/topics/getting_started.md | 0 doc/university/training/topics/git_add.md | 0 doc/university/training/topics/git_intro.md | 0 doc/university/training/topics/git_log.md | 0 doc/university/training/topics/gitlab_flow.md | 0 doc/university/training/topics/merge_conflicts.md | 0 doc/university/training/topics/merge_requests.md | 0 doc/university/training/topics/rollback_commits.md | 0 doc/university/training/topics/stash.md | 0 doc/university/training/topics/subtree.md | 0 doc/university/training/topics/tags.md | 0 doc/university/training/topics/unstage.md | 0 doc/university/training/user_training.md | 0 doc/user/project/integrations/img/webhook_logs.png | Bin doc/user/project/issues/img/button_close_issue.png | Bin doc/user/project/issues/img/closing_and_related_issues.png | Bin doc/user/project/issues/img/confidential_issues_create.png | Bin .../project/issues/img/confidential_issues_search_guest.png | Bin .../issues/img/confidential_issues_search_master.png | Bin doc/user/project/issues/img/due_dates_create.png | Bin doc/user/project/issues/img/due_dates_edit_sidebar.png | Bin doc/user/project/issues/img/due_dates_issues_index_page.png | Bin doc/user/project/issues/img/due_dates_todos.png | Bin doc/user/project/issues/img/issue_board.png | Bin doc/user/project/issues/img/issue_template.png | Bin doc/user/project/issues/img/mention_in_issue.png | Bin doc/user/project/issues/img/mention_in_merge_request.png | Bin doc/user/project/issues/img/merge_request_closes_issue.png | Bin doc/user/project/issues/img/new_issue.png | Bin doc/user/project/issues/img/new_issue_from_issue_board.png | Bin doc/user/project/issues/img/new_issue_from_open_issue.png | Bin .../issues/img/new_issue_from_projects_dashboard.png | Bin doc/user/project/issues/img/new_issue_from_tracker_list.png | Bin doc/user/project/issues/img/sidebar_confidential_issue.png | Bin .../project/issues/img/sidebar_not_confidential_issue.png | Bin doc/user/project/repository/img/contributors_graph.png | Bin doc/user/project/repository/img/repo_graph.png | Bin doc/user/project/settings/img/general_settings.png | Bin doc/user/project/settings/img/merge_requests_settings.png | Bin doc/user/search/img/issues_any_assignee.png | Bin doc/user/search/img/issues_assigned_to_you.png | Bin doc/user/search/img/issues_author.png | Bin doc/user/search/img/issues_mrs_shortcut.png | Bin doc/user/search/img/left_menu_bar.png | Bin doc/user/search/img/project_search.png | Bin doc/user/search/img/search_issues_board.png | Bin doc/user/search/img/sort_projects.png | Bin 56 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 doc/university/training/gitlab_flow.md mode change 100755 => 100644 doc/university/training/index.md mode change 100755 => 100644 doc/university/training/topics/additional_resources.md mode change 100755 => 100644 doc/university/training/topics/agile_git.md mode change 100755 => 100644 doc/university/training/topics/bisect.md mode change 100755 => 100644 doc/university/training/topics/cherry_picking.md mode change 100755 => 100644 doc/university/training/topics/env_setup.md mode change 100755 => 100644 doc/university/training/topics/explore_gitlab.md mode change 100755 => 100644 doc/university/training/topics/feature_branching.md mode change 100755 => 100644 doc/university/training/topics/getting_started.md mode change 100755 => 100644 doc/university/training/topics/git_add.md mode change 100755 => 100644 doc/university/training/topics/git_intro.md mode change 100755 => 100644 doc/university/training/topics/git_log.md mode change 100755 => 100644 doc/university/training/topics/gitlab_flow.md mode change 100755 => 100644 doc/university/training/topics/merge_conflicts.md mode change 100755 => 100644 doc/university/training/topics/merge_requests.md mode change 100755 => 100644 doc/university/training/topics/rollback_commits.md mode change 100755 => 100644 doc/university/training/topics/stash.md mode change 100755 => 100644 doc/university/training/topics/subtree.md mode change 100755 => 100644 doc/university/training/topics/tags.md mode change 100755 => 100644 doc/university/training/topics/unstage.md mode change 100755 => 100644 doc/university/training/user_training.md mode change 100755 => 100644 doc/user/project/integrations/img/webhook_logs.png mode change 100755 => 100644 doc/user/project/issues/img/button_close_issue.png mode change 100755 => 100644 doc/user/project/issues/img/closing_and_related_issues.png mode change 100755 => 100644 doc/user/project/issues/img/confidential_issues_create.png mode change 100755 => 100644 doc/user/project/issues/img/confidential_issues_search_guest.png mode change 100755 => 100644 doc/user/project/issues/img/confidential_issues_search_master.png mode change 100755 => 100644 doc/user/project/issues/img/due_dates_create.png mode change 100755 => 100644 doc/user/project/issues/img/due_dates_edit_sidebar.png mode change 100755 => 100644 doc/user/project/issues/img/due_dates_issues_index_page.png mode change 100755 => 100644 doc/user/project/issues/img/due_dates_todos.png mode change 100755 => 100644 doc/user/project/issues/img/issue_board.png mode change 100755 => 100644 doc/user/project/issues/img/issue_template.png mode change 100755 => 100644 doc/user/project/issues/img/mention_in_issue.png mode change 100755 => 100644 doc/user/project/issues/img/mention_in_merge_request.png mode change 100755 => 100644 doc/user/project/issues/img/merge_request_closes_issue.png mode change 100755 => 100644 doc/user/project/issues/img/new_issue.png mode change 100755 => 100644 doc/user/project/issues/img/new_issue_from_issue_board.png mode change 100755 => 100644 doc/user/project/issues/img/new_issue_from_open_issue.png mode change 100755 => 100644 doc/user/project/issues/img/new_issue_from_projects_dashboard.png mode change 100755 => 100644 doc/user/project/issues/img/new_issue_from_tracker_list.png mode change 100755 => 100644 doc/user/project/issues/img/sidebar_confidential_issue.png mode change 100755 => 100644 doc/user/project/issues/img/sidebar_not_confidential_issue.png mode change 100755 => 100644 doc/user/project/repository/img/contributors_graph.png mode change 100755 => 100644 doc/user/project/repository/img/repo_graph.png mode change 100755 => 100644 doc/user/project/settings/img/general_settings.png mode change 100755 => 100644 doc/user/project/settings/img/merge_requests_settings.png mode change 100755 => 100644 doc/user/search/img/issues_any_assignee.png mode change 100755 => 100644 doc/user/search/img/issues_assigned_to_you.png mode change 100755 => 100644 doc/user/search/img/issues_author.png mode change 100755 => 100644 doc/user/search/img/issues_mrs_shortcut.png mode change 100755 => 100644 doc/user/search/img/left_menu_bar.png mode change 100755 => 100644 doc/user/search/img/project_search.png mode change 100755 => 100644 doc/user/search/img/search_issues_board.png mode change 100755 => 100644 doc/user/search/img/sort_projects.png diff --git a/doc/university/training/gitlab_flow.md b/doc/university/training/gitlab_flow.md old mode 100755 new mode 100644 diff --git a/doc/university/training/index.md b/doc/university/training/index.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/additional_resources.md b/doc/university/training/topics/additional_resources.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/agile_git.md b/doc/university/training/topics/agile_git.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/bisect.md b/doc/university/training/topics/bisect.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/cherry_picking.md b/doc/university/training/topics/cherry_picking.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/env_setup.md b/doc/university/training/topics/env_setup.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/explore_gitlab.md b/doc/university/training/topics/explore_gitlab.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/feature_branching.md b/doc/university/training/topics/feature_branching.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/getting_started.md b/doc/university/training/topics/getting_started.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/git_add.md b/doc/university/training/topics/git_add.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/git_intro.md b/doc/university/training/topics/git_intro.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/git_log.md b/doc/university/training/topics/git_log.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/gitlab_flow.md b/doc/university/training/topics/gitlab_flow.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/merge_conflicts.md b/doc/university/training/topics/merge_conflicts.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/merge_requests.md b/doc/university/training/topics/merge_requests.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/rollback_commits.md b/doc/university/training/topics/rollback_commits.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/stash.md b/doc/university/training/topics/stash.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/subtree.md b/doc/university/training/topics/subtree.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/tags.md b/doc/university/training/topics/tags.md old mode 100755 new mode 100644 diff --git a/doc/university/training/topics/unstage.md b/doc/university/training/topics/unstage.md old mode 100755 new mode 100644 diff --git a/doc/university/training/user_training.md b/doc/university/training/user_training.md old mode 100755 new mode 100644 diff --git a/doc/user/project/integrations/img/webhook_logs.png b/doc/user/project/integrations/img/webhook_logs.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/button_close_issue.png b/doc/user/project/issues/img/button_close_issue.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/closing_and_related_issues.png b/doc/user/project/issues/img/closing_and_related_issues.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/confidential_issues_create.png b/doc/user/project/issues/img/confidential_issues_create.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/confidential_issues_search_guest.png b/doc/user/project/issues/img/confidential_issues_search_guest.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/confidential_issues_search_master.png b/doc/user/project/issues/img/confidential_issues_search_master.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/due_dates_create.png b/doc/user/project/issues/img/due_dates_create.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/due_dates_edit_sidebar.png b/doc/user/project/issues/img/due_dates_edit_sidebar.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/due_dates_issues_index_page.png b/doc/user/project/issues/img/due_dates_issues_index_page.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/due_dates_todos.png b/doc/user/project/issues/img/due_dates_todos.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/issue_board.png b/doc/user/project/issues/img/issue_board.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/issue_template.png b/doc/user/project/issues/img/issue_template.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/mention_in_issue.png b/doc/user/project/issues/img/mention_in_issue.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/mention_in_merge_request.png b/doc/user/project/issues/img/mention_in_merge_request.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/merge_request_closes_issue.png b/doc/user/project/issues/img/merge_request_closes_issue.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/new_issue.png b/doc/user/project/issues/img/new_issue.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/new_issue_from_issue_board.png b/doc/user/project/issues/img/new_issue_from_issue_board.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/new_issue_from_open_issue.png b/doc/user/project/issues/img/new_issue_from_open_issue.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/new_issue_from_projects_dashboard.png b/doc/user/project/issues/img/new_issue_from_projects_dashboard.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/new_issue_from_tracker_list.png b/doc/user/project/issues/img/new_issue_from_tracker_list.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/sidebar_confidential_issue.png b/doc/user/project/issues/img/sidebar_confidential_issue.png old mode 100755 new mode 100644 diff --git a/doc/user/project/issues/img/sidebar_not_confidential_issue.png b/doc/user/project/issues/img/sidebar_not_confidential_issue.png old mode 100755 new mode 100644 diff --git a/doc/user/project/repository/img/contributors_graph.png b/doc/user/project/repository/img/contributors_graph.png old mode 100755 new mode 100644 diff --git a/doc/user/project/repository/img/repo_graph.png b/doc/user/project/repository/img/repo_graph.png old mode 100755 new mode 100644 diff --git a/doc/user/project/settings/img/general_settings.png b/doc/user/project/settings/img/general_settings.png old mode 100755 new mode 100644 diff --git a/doc/user/project/settings/img/merge_requests_settings.png b/doc/user/project/settings/img/merge_requests_settings.png old mode 100755 new mode 100644 diff --git a/doc/user/search/img/issues_any_assignee.png b/doc/user/search/img/issues_any_assignee.png old mode 100755 new mode 100644 diff --git a/doc/user/search/img/issues_assigned_to_you.png b/doc/user/search/img/issues_assigned_to_you.png old mode 100755 new mode 100644 diff --git a/doc/user/search/img/issues_author.png b/doc/user/search/img/issues_author.png old mode 100755 new mode 100644 diff --git a/doc/user/search/img/issues_mrs_shortcut.png b/doc/user/search/img/issues_mrs_shortcut.png old mode 100755 new mode 100644 diff --git a/doc/user/search/img/left_menu_bar.png b/doc/user/search/img/left_menu_bar.png old mode 100755 new mode 100644 diff --git a/doc/user/search/img/project_search.png b/doc/user/search/img/project_search.png old mode 100755 new mode 100644 diff --git a/doc/user/search/img/search_issues_board.png b/doc/user/search/img/search_issues_board.png old mode 100755 new mode 100644 diff --git a/doc/user/search/img/sort_projects.png b/doc/user/search/img/sort_projects.png old mode 100755 new mode 100644 -- cgit v1.2.1 From 6532c137a74a23f062be29770c84ec2ab8cf5116 Mon Sep 17 00:00:00 2001 From: Achilleas Pipinellis Date: Mon, 25 Sep 2017 10:50:06 +0200 Subject: Add check for exec permissions and refactor lint doc script --- scripts/lint-doc.sh | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/scripts/lint-doc.sh b/scripts/lint-doc.sh index 54c1ef3dfdd..fffb727ac2f 100755 --- a/scripts/lint-doc.sh +++ b/scripts/lint-doc.sh @@ -3,15 +3,19 @@ cd "$(dirname "$0")/.." # Use long options (e.g. --header instead of -H) for curl examples in documentation. -grep --extended-regexp --recursive --color=auto 'curl (.+ )?-[^- ].*' doc/ +echo 'Checking for curl short options...' +grep --extended-regexp --recursive --color=auto 'curl (.+ )?-[^- ].*' doc/ >/dev/null 2>&1 if [ $? == 0 ] then - echo '✖ ERROR: Short options should not be used in documentation!' >&2 + echo '✖ ERROR: Short options for curl should not be used in documentation! + Use long options (e.g., --header instead of -H):' >&2 + grep --extended-regexp --recursive --color=auto 'curl (.+ )?-[^- ].*' doc/ exit 1 fi # Ensure that the CHANGELOG.md does not contain duplicate versions DUPLICATE_CHANGELOG_VERSIONS=$(grep --extended-regexp '^## .+' CHANGELOG.md | sed -E 's| \(.+\)||' | sort -r | uniq -d) +echo 'Checking for CHANGELOG.md duplicate entries...' if [ "${DUPLICATE_CHANGELOG_VERSIONS}" != "" ] then echo '✖ ERROR: Duplicate versions in CHANGELOG.md:' >&2 @@ -19,5 +23,16 @@ then exit 1 fi +# Make sure no files in doc/ are executable +EXEC_PERM_COUNT=$(find doc/ -type f -perm 755 | wc -l) +echo 'Checking for executable permissions...' +if [ "${EXEC_PERM_COUNT}" -ne 0 ] +then + echo '✖ ERROR: Executable permissions should not be used in documentation! Use `chmod 644` to the files in question:' >&2 + echo + find doc/ -type f -perm 755 + exit 1 +fi + echo "✔ Linting passed" exit 0 -- cgit v1.2.1 From 0741b86b2790dca9394f05ca19c336aaecb9d6cd Mon Sep 17 00:00:00 2001 From: Achilleas Pipinellis Date: Mon, 25 Sep 2017 10:59:25 +0200 Subject: Check for exec permissions also in app/ --- app/assets/images/favicon-blue.ico | Bin app/views/shared/icons/_icon_status_canceled.svg | 0 app/views/shared/icons/_icon_status_created.svg | 0 app/views/shared/icons/_icon_status_failed.svg | 0 app/views/shared/icons/_icon_status_manual.svg | 0 app/views/shared/icons/_icon_status_pending.svg | 0 app/views/shared/icons/_icon_status_running.svg | 0 app/views/shared/icons/_icon_status_skipped.svg | 0 app/views/shared/icons/_icon_status_success.svg | 0 app/views/shared/icons/_icon_status_warning.svg | 0 scripts/lint-doc.sh | 5 ++--- 11 files changed, 2 insertions(+), 3 deletions(-) mode change 100755 => 100644 app/assets/images/favicon-blue.ico mode change 100755 => 100644 app/views/shared/icons/_icon_status_canceled.svg mode change 100755 => 100644 app/views/shared/icons/_icon_status_created.svg mode change 100755 => 100644 app/views/shared/icons/_icon_status_failed.svg mode change 100755 => 100644 app/views/shared/icons/_icon_status_manual.svg mode change 100755 => 100644 app/views/shared/icons/_icon_status_pending.svg mode change 100755 => 100644 app/views/shared/icons/_icon_status_running.svg mode change 100755 => 100644 app/views/shared/icons/_icon_status_skipped.svg mode change 100755 => 100644 app/views/shared/icons/_icon_status_success.svg mode change 100755 => 100644 app/views/shared/icons/_icon_status_warning.svg diff --git a/app/assets/images/favicon-blue.ico b/app/assets/images/favicon-blue.ico old mode 100755 new mode 100644 diff --git a/app/views/shared/icons/_icon_status_canceled.svg b/app/views/shared/icons/_icon_status_canceled.svg old mode 100755 new mode 100644 diff --git a/app/views/shared/icons/_icon_status_created.svg b/app/views/shared/icons/_icon_status_created.svg old mode 100755 new mode 100644 diff --git a/app/views/shared/icons/_icon_status_failed.svg b/app/views/shared/icons/_icon_status_failed.svg old mode 100755 new mode 100644 diff --git a/app/views/shared/icons/_icon_status_manual.svg b/app/views/shared/icons/_icon_status_manual.svg old mode 100755 new mode 100644 diff --git a/app/views/shared/icons/_icon_status_pending.svg b/app/views/shared/icons/_icon_status_pending.svg old mode 100755 new mode 100644 diff --git a/app/views/shared/icons/_icon_status_running.svg b/app/views/shared/icons/_icon_status_running.svg old mode 100755 new mode 100644 diff --git a/app/views/shared/icons/_icon_status_skipped.svg b/app/views/shared/icons/_icon_status_skipped.svg old mode 100755 new mode 100644 diff --git a/app/views/shared/icons/_icon_status_success.svg b/app/views/shared/icons/_icon_status_success.svg old mode 100755 new mode 100644 diff --git a/app/views/shared/icons/_icon_status_warning.svg b/app/views/shared/icons/_icon_status_warning.svg old mode 100755 new mode 100644 diff --git a/scripts/lint-doc.sh b/scripts/lint-doc.sh index fffb727ac2f..e5242fee32b 100755 --- a/scripts/lint-doc.sh +++ b/scripts/lint-doc.sh @@ -24,13 +24,12 @@ then fi # Make sure no files in doc/ are executable -EXEC_PERM_COUNT=$(find doc/ -type f -perm 755 | wc -l) +EXEC_PERM_COUNT=$(find doc/ app/ -type f -perm 755 | wc -l) echo 'Checking for executable permissions...' if [ "${EXEC_PERM_COUNT}" -ne 0 ] then echo '✖ ERROR: Executable permissions should not be used in documentation! Use `chmod 644` to the files in question:' >&2 - echo - find doc/ -type f -perm 755 + find doc/ app/ -type f -perm 755 exit 1 fi -- cgit v1.2.1