From eeb25534bae1021f5b7940138ee56dea8fc79949 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 17 May 2023 09:10:09 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- .../rspec/avoid_conditional_statements.yml | 1 - .../boards/components/board_content.vue | 2 +- .../javascripts/graphql_shared/issuable_client.js | 10 + .../components/packages_cleanup_policy_form.vue | 2 +- .../permissions/components/settings_panel.vue | 10 +- .../repository/components/fork_info.vue | 2 +- .../work_items/components/notes/system_note.vue | 107 +------ .../components/work_item_description.vue | 4 +- .../work_items/components/work_item_notes.vue | 6 +- .../notes/create_work_item_note.mutation.graphql | 2 +- .../notes/update_work_item_note.mutation.graphql | 2 +- .../work_item_discussion_note.fragment.graphql | 2 +- .../graphql/notes/work_item_note.fragment.graphql | 7 + .../work_item_note_updated.subscription.graphql | 2 +- .../notes/work_item_notes_by_iid.query.graphql | 2 +- .../mixins/description_version_history.js | 14 + .../javascripts/work_items/notes/collapse_utils.js | 92 ++++++ app/views/shared/projects/_project.html.haml | 2 +- .../16_0/16-0-source-code-approvals-endpoint.yml | 30 ++ doc/api/merge_request_approvals.md | 14 + doc/api/search_admin.md | 125 ++++++++ doc/update/removals.md | 10 + doc/user/group/epics/index.md | 7 + doc/user/project/issues/index.md | 7 + spec/features/snippets/explore_spec.rb | 20 +- .../boards/components/board_content_spec.js | 24 ++ .../components/notes/system_note_spec.js | 96 +----- .../components/notes/work_item_add_note_spec.js | 2 +- .../work_items/components/work_item_labels_spec.js | 2 +- spec/frontend/work_items/mock_data.js | 353 +++++++++++++++++++++ .../work_items/notes/collapse_utils_spec.js | 29 ++ 31 files changed, 791 insertions(+), 197 deletions(-) create mode 100644 app/assets/javascripts/work_items/mixins/description_version_history.js create mode 100644 app/assets/javascripts/work_items/notes/collapse_utils.js create mode 100644 data/removals/16_0/16-0-source-code-approvals-endpoint.yml create mode 100644 doc/api/search_admin.md create mode 100644 spec/frontend/work_items/notes/collapse_utils_spec.js diff --git a/.rubocop_todo/rspec/avoid_conditional_statements.yml b/.rubocop_todo/rspec/avoid_conditional_statements.yml index 4817708667a..4a4ba87eab3 100644 --- a/.rubocop_todo/rspec/avoid_conditional_statements.yml +++ b/.rubocop_todo/rspec/avoid_conditional_statements.yml @@ -77,7 +77,6 @@ RSpec/AvoidConditionalStatements: - 'spec/features/projects/tree/create_file_spec.rb' - 'spec/features/projects_spec.rb' - 'spec/features/search/user_uses_header_search_field_spec.rb' - - 'spec/features/snippets/explore_spec.rb' - 'spec/features/usage_stats_consent_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/features/users/overview_spec.rb' diff --git a/app/assets/javascripts/boards/components/board_content.vue b/app/assets/javascripts/boards/components/board_content.vue index 8304dfef527..9416cbf1884 100644 --- a/app/assets/javascripts/boards/components/board_content.vue +++ b/app/assets/javascripts/boards/components/board_content.vue @@ -130,7 +130,7 @@ export default { :list="list" :filters="filterParams" :data-draggable-item-type="$options.draggableItemTypes.list" - :class="{ 'gl-xs-display-none!': addColumnFormVisible }" + :class="{ 'gl-display-none! gl-sm-display-inline-block!': addColumnFormVisible }" @setActiveList="$emit('setActiveList', $event)" /> diff --git a/app/assets/javascripts/graphql_shared/issuable_client.js b/app/assets/javascripts/graphql_shared/issuable_client.js index d0b0a485fe6..706bfc9bdac 100644 --- a/app/assets/javascripts/graphql_shared/issuable_client.js +++ b/app/assets/javascripts/graphql_shared/issuable_client.js @@ -47,6 +47,16 @@ export const config = { }, }, }, + DescriptionVersion: { + fields: { + startVersionId: { + read() { + // we need to set this when fetching the diff in the last 10 mins , the starting diff will be the very first one , so need to save it + return ''; + }, + }, + }, + }, WorkItem: { fields: { // widgets policy because otherwise the subscriptions invalidate the cache diff --git a/app/assets/javascripts/packages_and_registries/settings/project/components/packages_cleanup_policy_form.vue b/app/assets/javascripts/packages_and_registries/settings/project/components/packages_cleanup_policy_form.vue index f95ec4336dc..80df8ef81e6 100644 --- a/app/assets/javascripts/packages_and_registries/settings/project/components/packages_cleanup_policy_form.vue +++ b/app/assets/javascripts/packages_and_registries/settings/project/components/packages_cleanup_policy_form.vue @@ -139,7 +139,7 @@ export default { :form-options="$options.formOptions.keepNDuplicatedPackageFiles" :label="$options.i18n.KEEP_N_DUPLICATED_PACKAGE_FILES_LABEL" :description="$options.i18n.KEEP_N_DUPLICATED_PACKAGE_FILES_DESCRIPTION" - dropdown-class="gl-md-max-w-50p gl-sm-pr-5" + dropdown-class="gl-md-max-w-50p" name="keep-n-duplicated-package-files" data-testid="keep-n-duplicated-package-files-dropdown" @input="onModelChange($event, 'keepNDuplicatedPackageFiles')" diff --git a/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue index 64c363dd721..031910b1cdb 100644 --- a/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue +++ b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue @@ -552,7 +552,7 @@ export default {