From f10327de8a0c0039e28c296807d84bda69a3e284 Mon Sep 17 00:00:00 2001 From: Jan Provaznik Date: Wed, 18 Apr 2018 12:29:11 +0200 Subject: Added a comment about extra query for label ids --- app/services/labels/transfer_service.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/services/labels/transfer_service.rb b/app/services/labels/transfer_service.rb index 31f41fc75ec..9b7486cf53b 100644 --- a/app/services/labels/transfer_service.rb +++ b/app/services/labels/transfer_service.rb @@ -65,7 +65,10 @@ module Labels def update_label_links(labels, old_label_id:, new_label_id:) # use 'labels' relation to get label_link ids only of issues/MRs - # in the project being transferred + # in the project being transferred. + # IDs are fetched in a separate query because MySQL doesn't + # allow referring of 'label_links' table in UPDATE query: + # https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/62435068 link_ids = labels.pluck('label_links.id') LabelLink.where(id: link_ids, label_id: old_label_id) -- cgit v1.2.1