From 0cfca15292570197ec08bc9aa2bd550a0bcefc2d Mon Sep 17 00:00:00 2001 From: Jeroen van Baarsen Date: Sat, 13 Dec 2014 20:09:26 +0100 Subject: Added process for green tests Signed-off-by: Jeroen van Baarsen --- PROCESS.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/PROCESS.md b/PROCESS.md index 1dd28d6b670..310b98c9324 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -104,3 +104,10 @@ This merge request has been closed because a request for more information has no ### Accepting merge requests Is there a request on [the feature request forum](http://feedback.gitlab.com/forums/176466-general) that is similar to this? If so, can you make a comment with a link to it? Please be aware that new functionality that is not marked [accepting merge/pull requests](http://feedback.gitlab.com/forums/176466-general/status/796455) on the forum might not make it into GitLab. You might be asked to make changes and even after implementing them your feature might still be declined. If you want to reduce the chance of this happening please have a discussion in the forum first. + +### Only accepting merge requests with green tests + +We can only accept a merge requests if all the tests are green, can you please +make sure the tests of this merge requests are green? If the failing test has +nothing do to with your merge request, you might want to rebase with master to +see if that makes the tests green again. -- cgit v1.2.1 From 5ad463e0e89084133c764f20d030aae33b9aa907 Mon Sep 17 00:00:00 2001 From: Jeroen van Baarsen Date: Mon, 15 Dec 2014 10:41:30 +0100 Subject: Rephrase of the text Signed-off-by: Jeroen van Baarsen --- PROCESS.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index 310b98c9324..5cc25de05a4 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -107,7 +107,7 @@ Is there a request on [the feature request forum](http://feedback.gitlab.com/for ### Only accepting merge requests with green tests -We can only accept a merge requests if all the tests are green, can you please -make sure the tests of this merge requests are green? If the failing test has -nothing do to with your merge request, you might want to rebase with master to -see if that makes the tests green again. +We can only accept a merge request if all the tests are green. I've just +restarted the build. When the tests are still not passing after this restart and +you're sure that is does not have anything to do with your code changes, please +rebase with master to see if that solves the issue. -- cgit v1.2.1