From faa95ba4fbeb93e6af19770f7aade54aa9d30304 Mon Sep 17 00:00:00 2001 From: James Lopez Date: Wed, 20 Sep 2017 12:31:35 +0200 Subject: fix users update service --- app/services/users/update_service.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/services/users/update_service.rb b/app/services/users/update_service.rb index 05cb1655325..9f013af38dc 100644 --- a/app/services/users/update_service.rb +++ b/app/services/users/update_service.rb @@ -11,10 +11,12 @@ module Users def execute(validate: true, &block) yield(@user) if block_given? + user_exists = @user.persisted? + assign_attributes(&block) if @user.save(validate: validate) - notify_success + notify_success(user_exists) else error(@user.errors.full_messages.uniq.join('. ')) end @@ -30,8 +32,8 @@ module Users private - def notify_success - notify_new_user(@user, nil) unless @user.persisted? + def notify_success(user_exists) + notify_new_user(@user, nil) unless user_exists success end -- cgit v1.2.1