From fc464f1ff27734df81f7f85cbc23e93902c97cda Mon Sep 17 00:00:00 2001 From: Valery Sizov Date: Thu, 4 May 2017 20:22:03 +0300 Subject: Multiple issue assignee: fixed services/issues/update_service by using new NoteSummary --- app/services/system_note_service.rb | 2 +- spec/features/boards/sidebar_spec.rb | 21 --------------------- 2 files changed, 1 insertion(+), 22 deletions(-) diff --git a/app/services/system_note_service.rb b/app/services/system_note_service.rb index 898c69b3f8c..1dee791cfd6 100644 --- a/app/services/system_note_service.rb +++ b/app/services/system_note_service.rb @@ -84,7 +84,7 @@ module SystemNoteService "assigned to #{issue.assignees.map(&:to_reference).to_sentence}" end - create_note(noteable: issue, project: project, author: author, note: body) + NoteSummary.new(issue, project, author, body, action: 'assignee') end # Called when one or more labels on a Noteable are added and/or removed diff --git a/spec/features/boards/sidebar_spec.rb b/spec/features/boards/sidebar_spec.rb index 02b6b5dc888..7c53d2b47d9 100644 --- a/spec/features/boards/sidebar_spec.rb +++ b/spec/features/boards/sidebar_spec.rb @@ -21,7 +21,6 @@ describe 'Issue Boards', feature: true, js: true do Timecop.freeze project.team << [user, :master] - project.team.add_developer(user2) login_as(user) @@ -103,26 +102,6 @@ describe 'Issue Boards', feature: true, js: true do expect(card).to have_selector('.avatar') end - it 'adds multiple assignees' do - click_card(card) - - page.within('.assignee') do - click_link 'Edit' - - wait_for_ajax - - page.within('.dropdown-menu-user') do - click_link user.name - click_link user2.name - end - - expect(page).to have_content(user.name) - expect(page).to have_content(user2.name) - end - - expect(card.all('.avatar').length).to eq(2) - end - it 'removes the assignee' do card_two = first('.board').find('.card:nth-child(2)') click_card(card_two) -- cgit v1.2.1