From 112d540df4a37aeca198dc39e715e04e3655c1f7 Mon Sep 17 00:00:00 2001
From: kushalpandya <kushal@gitlab.com>
Date: Wed, 31 May 2017 20:25:57 +0530
Subject: Action link role sets to `button` if no HREF is given

---
 app/assets/javascripts/flash.js | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

(limited to 'app/assets/javascripts/flash.js')

diff --git a/app/assets/javascripts/flash.js b/app/assets/javascripts/flash.js
index de909946271..ccff8f0ace7 100644
--- a/app/assets/javascripts/flash.js
+++ b/app/assets/javascripts/flash.js
@@ -45,11 +45,17 @@ window.Flash = (function() {
     textDiv.appendTo(flash);
 
     if (actionConfig) {
-      actionLink = $('<a/>', {
+      const actionLinkConfig = {
         class: 'flash-action',
         href: actionConfig.href || '#',
         text: actionConfig.title
-      });
+      };
+
+      if (!actionConfig.href) {
+        actionLinkConfig.role = 'button';
+      }
+
+      actionLink = $('<a/>', actionLinkConfig);
 
       actionLink.appendTo(flash);
       this.flashContainer.on('click', '.flash-action', actionConfig.clickHandler);
-- 
cgit v1.2.1