From 95f73a68fa3ff235c35217b1c72666c5bad6ce03 Mon Sep 17 00:00:00 2001
From: Robert Speicher <rspeicher@gmail.com>
Date: Wed, 23 Sep 2015 00:24:17 -0400
Subject: Simplify help path prefixing

---
 app/controllers/help_controller.rb | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)

(limited to 'app/controllers/help_controller.rb')

diff --git a/app/controllers/help_controller.rb b/app/controllers/help_controller.rb
index 7283c4f4a4c..55050615473 100644
--- a/app/controllers/help_controller.rb
+++ b/app/controllers/help_controller.rb
@@ -5,7 +5,10 @@ class HelpController < ApplicationController
 
   def index
     @help_index = File.read(Rails.root.join('doc', 'README.md'))
-    prefix_help_links!(@help_index)
+
+    # Prefix Markdown links with `help/` unless they already have been
+    # See http://rubular.com/r/nwwhzH6Z8X
+    @help_index.gsub!(/(\]\()(?!help\/)([^\)\(]+)(\))/, '\1help/\2\3')
   end
 
   def show
@@ -59,22 +62,6 @@ class HelpController < ApplicationController
     params
   end
 
-  # Prefix links in a Markdown document with `help/` unless they already have
-  # been
-  #
-  # TODO (rspeicher): This should be a pipeline filter that only gets included
-  # for help pages, and it should operate on the Nokogiri doc to be more robust.
-  #
-  # text - Markdown String
-  #
-  # Modifies `text` in-place
-  def prefix_help_links!(text)
-    # Match text inside a Markdown link unless it already starts with `help/`
-    #
-    # See http://rubular.com/r/nwwhzH6Z8X
-    text.gsub!(%r{(\]\()(?!help\/)([^\)\(]+)(\))}x, '\1help/\2\3')
-  end
-
   PATH_SEPS = Regexp.union(*[::File::SEPARATOR, ::File::ALT_SEPARATOR].compact)
 
   # Taken from ActionDispatch::FileHandler
-- 
cgit v1.2.1