From 0e5fbb29f42e43c2b43192d61d47402602dfd84f Mon Sep 17 00:00:00 2001 From: Robert Speicher Date: Wed, 8 Jul 2015 17:56:56 -0400 Subject: Remove unused `task_[un]check` states from Update services These were left over from the old Task handling. --- app/services/issues/update_service.rb | 7 +------ app/services/merge_requests/update_service.rb | 6 +----- 2 files changed, 2 insertions(+), 11 deletions(-) (limited to 'app') diff --git a/app/services/issues/update_service.rb b/app/services/issues/update_service.rb index 3220facaf7c..e3b508d4965 100644 --- a/app/services/issues/update_service.rb +++ b/app/services/issues/update_service.rb @@ -8,10 +8,6 @@ module Issues Issues::ReopenService.new(project, current_user, {}).execute(issue) when 'close' Issues::CloseService.new(project, current_user, {}).execute(issue) - when 'task_check' - issue.update_nth_task(params[:task_num].to_i, true) - when 'task_uncheck' - issue.update_nth_task(params[:task_num].to_i, false) end params[:assignee_id] = "" if params[:assignee_id] == IssuableFinder::NONE @@ -20,8 +16,7 @@ module Issues filter_params old_labels = issue.labels.to_a - if params.present? && issue.update_attributes(params.except(:state_event, - :task_num)) + if params.present? && issue.update_attributes(params.except(:state_event)) issue.reset_events_cache if issue.labels != old_labels diff --git a/app/services/merge_requests/update_service.rb b/app/services/merge_requests/update_service.rb index f6570f52241..108d755aa03 100644 --- a/app/services/merge_requests/update_service.rb +++ b/app/services/merge_requests/update_service.rb @@ -18,10 +18,6 @@ module MergeRequests MergeRequests::ReopenService.new(project, current_user, {}).execute(merge_request) when 'close' MergeRequests::CloseService.new(project, current_user, {}).execute(merge_request) - when 'task_check' - merge_request.update_nth_task(params[:task_num].to_i, true) - when 'task_uncheck' - merge_request.update_nth_task(params[:task_num].to_i, false) end params[:assignee_id] = "" if params[:assignee_id] == IssuableFinder::NONE @@ -31,7 +27,7 @@ module MergeRequests old_labels = merge_request.labels.to_a if params.present? && merge_request.update_attributes( - params.except(:state_event, :task_num) + params.except(:state_event) ) merge_request.reset_events_cache -- cgit v1.2.1