From 666ddec9b209d795ee315d1ea896feb04c30e048 Mon Sep 17 00:00:00 2001 From: Mark Chao Date: Mon, 1 Oct 2018 11:02:38 +0800 Subject: Combine two updates in one query --- app/models/project.rb | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'app') diff --git a/app/models/project.rb b/app/models/project.rb index fa995b5b061..08315606711 100644 --- a/app/models/project.rb +++ b/app/models/project.rb @@ -95,8 +95,7 @@ class Project < ActiveRecord::Base unless: :ci_cd_settings, if: proc { ProjectCiCdSetting.available? } - after_create :set_last_activity_at - after_create :set_last_repository_updated_at + after_create :set_timestamps_for_create after_update :update_forks_visibility_level before_destroy :remove_private_deploy_keys @@ -2102,13 +2101,8 @@ class Project < ActiveRecord::Base gitlab_shell.exists?(repository_storage, "#{disk_path}.git") end - # set last_activity_at to the same as created_at - def set_last_activity_at - update_column(:last_activity_at, self.created_at) - end - - def set_last_repository_updated_at - update_column(:last_repository_updated_at, self.created_at) + def set_timestamps_for_create + update_columns(last_activity_at: self.created_at, last_repository_updated_at: self.created_at) end def cross_namespace_reference?(from) -- cgit v1.2.1