From e2c87838157d90062725fd648788c6e1839bc8d8 Mon Sep 17 00:00:00 2001 From: Mike Greiling Date: Thu, 1 Mar 2018 01:47:06 -0600 Subject: migrate notebook_viewer to dynamic import --- app/assets/javascripts/blob/notebook_viewer.js | 2 +- app/assets/javascripts/blob/viewer/index.js | 3 +++ app/views/projects/blob/viewers/_notebook.html.haml | 4 ---- 3 files changed, 4 insertions(+), 5 deletions(-) (limited to 'app') diff --git a/app/assets/javascripts/blob/notebook_viewer.js b/app/assets/javascripts/blob/notebook_viewer.js index b7a0a195a92..226ae69893e 100644 --- a/app/assets/javascripts/blob/notebook_viewer.js +++ b/app/assets/javascripts/blob/notebook_viewer.js @@ -1,3 +1,3 @@ import renderNotebook from './notebook'; -document.addEventListener('DOMContentLoaded', renderNotebook); +export default renderNotebook; diff --git a/app/assets/javascripts/blob/viewer/index.js b/app/assets/javascripts/blob/viewer/index.js index 0f1f026dc8b..0574b5b79aa 100644 --- a/app/assets/javascripts/blob/viewer/index.js +++ b/app/assets/javascripts/blob/viewer/index.js @@ -32,6 +32,9 @@ export default class BlobViewer { case 'balsamiq': initViewer(import(/* webpackChunkName: 'balsamiq_viewer' */ '../balsamiq_viewer')); break; + case 'notebook': + initViewer(import(/* webpackChunkName: 'notebook_viewer' */ '../notebook_viewer')); + break; default: break; } diff --git a/app/views/projects/blob/viewers/_notebook.html.haml b/app/views/projects/blob/viewers/_notebook.html.haml index d1ffaca35b9..eb4ca1b9816 100644 --- a/app/views/projects/blob/viewers/_notebook.html.haml +++ b/app/views/projects/blob/viewers/_notebook.html.haml @@ -1,5 +1 @@ -- content_for :page_specific_javascripts do - = webpack_bundle_tag('common_vue') - = webpack_bundle_tag('notebook_viewer') - .file-content#js-notebook-viewer{ data: { endpoint: blob_raw_path } } -- cgit v1.2.1