From 7fe15d4fb05721a5a4e2a641f36f17819ccba834 Mon Sep 17 00:00:00 2001 From: Maxim Rydkin Date: Thu, 24 Aug 2017 12:10:24 +0300 Subject: adds changelog --- changelogs/unreleased/24121_extract_yet_another_users_finder.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/24121_extract_yet_another_users_finder.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/24121_extract_yet_another_users_finder.yml b/changelogs/unreleased/24121_extract_yet_another_users_finder.yml new file mode 100644 index 00000000000..b6c691561bc --- /dev/null +++ b/changelogs/unreleased/24121_extract_yet_another_users_finder.yml @@ -0,0 +1,5 @@ +--- +title: Extract AutocompleteController#users into finder +merge_request: 13778 +author: Maxim Rydkin +type: other -- cgit v1.2.1 From 27df56ad129ec145754ef16cc2c670850b7a5101 Mon Sep 17 00:00:00 2001 From: Maxim Rydkin Date: Fri, 8 Sep 2017 18:17:55 +0300 Subject: add Mayra Cabrera to authors of change --- changelogs/unreleased/24121_extract_yet_another_users_finder.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'changelogs') diff --git a/changelogs/unreleased/24121_extract_yet_another_users_finder.yml b/changelogs/unreleased/24121_extract_yet_another_users_finder.yml index b6c691561bc..e43e97303e2 100644 --- a/changelogs/unreleased/24121_extract_yet_another_users_finder.yml +++ b/changelogs/unreleased/24121_extract_yet_another_users_finder.yml @@ -1,5 +1,5 @@ --- title: Extract AutocompleteController#users into finder merge_request: 13778 -author: Maxim Rydkin +author: Maxim Rydkin, Mayra Cabrera type: other -- cgit v1.2.1 From 056c42cca5aa21fb2ebc9e5fc2cbedf18cf8dbbc Mon Sep 17 00:00:00 2001 From: Felipe Artur Date: Tue, 12 Sep 2017 18:07:11 -0300 Subject: Fix project feature being deleted when updating project with invalid visibility level --- changelogs/unreleased/issue_37640.yml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 changelogs/unreleased/issue_37640.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/issue_37640.yml b/changelogs/unreleased/issue_37640.yml new file mode 100644 index 00000000000..d806ed64bed --- /dev/null +++ b/changelogs/unreleased/issue_37640.yml @@ -0,0 +1,6 @@ +--- +title: Fix project feature being deleted when updating project with invalid visibility + level +merge_request: +author: +type: fixed -- cgit v1.2.1 From ba3376f3796c434d4b8342c71bda8e580d923c0a Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Wed, 13 Sep 2017 20:36:42 +0800 Subject: Add changelog entry --- changelogs/unreleased/37759-also-treat-newlines-as-separator.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/37759-also-treat-newlines-as-separator.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/37759-also-treat-newlines-as-separator.yml b/changelogs/unreleased/37759-also-treat-newlines-as-separator.yml new file mode 100644 index 00000000000..6894e650c11 --- /dev/null +++ b/changelogs/unreleased/37759-also-treat-newlines-as-separator.yml @@ -0,0 +1,5 @@ +--- +title: Allow using newlines in pipeline email service recipients +merge_request: 14250 +author: +type: fixed -- cgit v1.2.1 From f04094a4f8f8c307d05d3e8571cfcd44c586c599 Mon Sep 17 00:00:00 2001 From: Yorick Peterse Date: Wed, 13 Sep 2017 14:43:03 +0200 Subject: Constrain environment deployments to project IDs When querying the deployments of an environment the query Rails produces will be along the lines of the following: SELECT * FROM deployments WHERE environment_id = X For queries such as this (or queries that use this as their base and add more conditions) there is no meaningful index that can be used as long as deployments.project_id is not part of a WHERE clause. To work around this we change that "has_many :deployments" relation to always add a "WHERE project_id = X" condition. This means that queries filtering deployments can make better use of the existing indexes. For example, when filtering by deployments.iid this will result in the following query: SELECT * FROM deployments WHERE environment_id = X AND project_id = Y AND iid = Z This means PostgreSQL can use the existing index on (project_id, environment_id, iid) instead of having to use a different index (or none at all) and having to scan over a large amount of data. Query plan wise this means that instead of this query and plan: EXPLAIN (BUFFERS, ANALYZE) SELECT deployments.* FROM deployments WHERE deployments.environment_id = 5 AND deployments.iid = 225; Index Scan using index_deployments_on_project_id_and_iid on deployments (cost=0.42..14465.75 rows=1 width=117) (actual time=6.394..38.048 rows=1 loops=1) Index Cond: (iid = 225) Filter: (environment_id = 5) Rows Removed by Filter: 839 Buffers: shared hit=4534 Planning time: 0.076 ms Execution time: 38.073 ms We produce the following query and plan: EXPLAIN (BUFFERS, ANALYZE) SELECT deployments.* FROM deployments WHERE deployments.environment_id = 5 AND deployments.iid = 225 AND deployments.project_id = 1292351; Index Scan using index_deployments_on_project_id_and_iid on deployments (cost=0.42..4.45 rows=1 width=117) (actual time=0.018..0.018 rows=1 loops=1) Index Cond: ((project_id = 1292351) AND (iid = 225)) Filter: (environment_id = 5) Buffers: shared hit=4 Planning time: 0.088 ms Execution time: 0.039 ms On GitLab.com these changes result in a (roughly) 11x improvement in SQL timings for the CI environment status endpoint. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36877 --- changelogs/unreleased/ci-environment-status-performance.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/ci-environment-status-performance.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/ci-environment-status-performance.yml b/changelogs/unreleased/ci-environment-status-performance.yml new file mode 100644 index 00000000000..8812733b5a7 --- /dev/null +++ b/changelogs/unreleased/ci-environment-status-performance.yml @@ -0,0 +1,5 @@ +--- +title: Constrain environment deployments to project IDs +merge_request: +author: +type: other -- cgit v1.2.1 From 9230caa907156354d6b9889eee1c4e30a4737471 Mon Sep 17 00:00:00 2001 From: Yorick Peterse Date: Wed, 13 Sep 2017 15:16:24 +0200 Subject: Disallow NULL values for environments.project_id --- .../unreleased/disallow-null-values-for-environments-project-id.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/disallow-null-values-for-environments-project-id.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/disallow-null-values-for-environments-project-id.yml b/changelogs/unreleased/disallow-null-values-for-environments-project-id.yml new file mode 100644 index 00000000000..f4a956e6724 --- /dev/null +++ b/changelogs/unreleased/disallow-null-values-for-environments-project-id.yml @@ -0,0 +1,5 @@ +--- +title: "Disallow NULL values for environments.project_id" +merge_request: +author: +type: other -- cgit v1.2.1 From ce6a02eeb4633198f6c0e1a1b7629177efd8aec4 Mon Sep 17 00:00:00 2001 From: Bryce Johnson Date: Mon, 11 Sep 2017 09:53:13 -0400 Subject: Remove animate.js and the issuable label pulse animation. Nobody tell @jschatz1 :P --- changelogs/unreleased/refactor-animate-js.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/refactor-animate-js.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/refactor-animate-js.yml b/changelogs/unreleased/refactor-animate-js.yml new file mode 100644 index 00000000000..ec32d68bbdd --- /dev/null +++ b/changelogs/unreleased/refactor-animate-js.yml @@ -0,0 +1,5 @@ +--- +title: Remove animate.js and label animation. +merge_request: +author: +type: removed -- cgit v1.2.1 From dea0cb47611709e23204f59ea314dd04c26c7664 Mon Sep 17 00:00:00 2001 From: Dimitrie Hoekstra Date: Mon, 4 Sep 2017 23:22:11 +0200 Subject: changed dashed border button color to be darker --- changelogs/unreleased/change-dashed-border-button-color.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/change-dashed-border-button-color.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/change-dashed-border-button-color.yml b/changelogs/unreleased/change-dashed-border-button-color.yml new file mode 100644 index 00000000000..038bea79273 --- /dev/null +++ b/changelogs/unreleased/change-dashed-border-button-color.yml @@ -0,0 +1,5 @@ +--- +title: changed dashed border button color to be darker +merge_request: !14041 +author: +type: other -- cgit v1.2.1 From 3e999684f9c3b7306dea7a7feee90536ee100ccf Mon Sep 17 00:00:00 2001 From: Yorick Peterse Date: Tue, 12 Sep 2017 15:54:25 +0200 Subject: Memoize pipelines for project download buttons This adds Project#latest_successful_pipeline_for and Project#latest_successful_pipeline_for_default_branch. The 2nd method memoizes the result (taking nil values into account) to ensure the underlying query isn't executed multiple times when viewing a project's homepage. See https://gitlab.com/gitlab-org/gitlab-ce/issues/36878#note_40073607 for more information. --- changelogs/unreleased/projects-controller-show.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/projects-controller-show.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/projects-controller-show.yml b/changelogs/unreleased/projects-controller-show.yml new file mode 100644 index 00000000000..25f4a72710b --- /dev/null +++ b/changelogs/unreleased/projects-controller-show.yml @@ -0,0 +1,5 @@ +--- +title: Memoize pipelines for project download buttons +merge_request: +author: +type: other -- cgit v1.2.1 From 72190099934badcb3296983a457123c9e0303060 Mon Sep 17 00:00:00 2001 From: Yorick Peterse Date: Tue, 12 Sep 2017 18:13:07 +0200 Subject: Memoize the latest builds of a pipeline This ensures that if a pipeline is present for the last commit on a project's homepage we only run 1 query to get the builds, instead of running 2 queries. See https://gitlab.com/gitlab-org/gitlab-ce/issues/36878#note_40073339 for more information. --- changelogs/unreleased/memoize-the-latest-builds-of-a-pipeline.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/memoize-the-latest-builds-of-a-pipeline.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/memoize-the-latest-builds-of-a-pipeline.yml b/changelogs/unreleased/memoize-the-latest-builds-of-a-pipeline.yml new file mode 100644 index 00000000000..5a7cd42b888 --- /dev/null +++ b/changelogs/unreleased/memoize-the-latest-builds-of-a-pipeline.yml @@ -0,0 +1,5 @@ +--- +title: "Memoize the latest builds of a pipeline on a project's homepage" +merge_request: +author: +type: other -- cgit v1.2.1 From b06d5b963a11ad695a8d0d0db75480e2290b155f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= Date: Wed, 13 Sep 2017 14:15:07 +0200 Subject: Return only group's members in user dropdowns on issuables list pages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Rémy Coutable --- .../20824-scope-users-to-members-in-group-issuable-list.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/20824-scope-users-to-members-in-group-issuable-list.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/20824-scope-users-to-members-in-group-issuable-list.yml b/changelogs/unreleased/20824-scope-users-to-members-in-group-issuable-list.yml new file mode 100644 index 00000000000..245b8129de8 --- /dev/null +++ b/changelogs/unreleased/20824-scope-users-to-members-in-group-issuable-list.yml @@ -0,0 +1,5 @@ +--- +title: Return only group's members in user dropdowns on issuables list pages +merge_request: 14249 +author: +type: changed -- cgit v1.2.1 From 3140006355e35663ca0f4f6e2b4a2157d39480cd Mon Sep 17 00:00:00 2001 From: Jedidiah Date: Thu, 14 Sep 2017 17:58:15 +0000 Subject: Add missing classes to omniauth remember-me checkbox and add correct font-size --- changelogs/unreleased/uipolish-fix-remember-me-checkbox.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/uipolish-fix-remember-me-checkbox.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/uipolish-fix-remember-me-checkbox.yml b/changelogs/unreleased/uipolish-fix-remember-me-checkbox.yml new file mode 100644 index 00000000000..34aa3d0db6f --- /dev/null +++ b/changelogs/unreleased/uipolish-fix-remember-me-checkbox.yml @@ -0,0 +1,5 @@ +--- +title: Made the "remember me" check boxes have consistent styles and alignment +merge_request: +author: Jedidiah Broadbent +type: fixed -- cgit v1.2.1 From c456cc718bc88b2ce66974d0f75224472a2894e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= Date: Tue, 12 Sep 2017 16:56:22 +0200 Subject: Make the labels in the Compare form less confusing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Improve the descriptive text * Rename "from" to "Target" and "to" to "Source" * Swap "Target" and "Source" to have the same order as in MRs * Reworded "Switch base of comparison" to "Swap versions" Signed-off-by: Rémy Coutable --- changelogs/unreleased/21331-improve-confusing-compare-page.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/21331-improve-confusing-compare-page.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/21331-improve-confusing-compare-page.yml b/changelogs/unreleased/21331-improve-confusing-compare-page.yml new file mode 100644 index 00000000000..469cc04930b --- /dev/null +++ b/changelogs/unreleased/21331-improve-confusing-compare-page.yml @@ -0,0 +1,5 @@ +--- +title: Make the labels in the Compare form less confusing +merge_request: 14225 +author: +type: changed -- cgit v1.2.1 From 72a30d613404ed9a77ad8062f311cac7aece0370 Mon Sep 17 00:00:00 2001 From: Winnie Hellmann Date: Fri, 15 Sep 2017 12:33:50 +0000 Subject: Display whether branch has been merged when deleting protected branch --- changelogs/unreleased/winh-protected-branch-modal-merged.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/winh-protected-branch-modal-merged.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/winh-protected-branch-modal-merged.yml b/changelogs/unreleased/winh-protected-branch-modal-merged.yml new file mode 100644 index 00000000000..63f1f424a5d --- /dev/null +++ b/changelogs/unreleased/winh-protected-branch-modal-merged.yml @@ -0,0 +1,5 @@ +--- +title: Display whether branch has been merged when deleting protected branch +merge_request: 14220 +author: +type: changed -- cgit v1.2.1 From cc2daa74d83c98dc05dd92f0950a122b46b83c96 Mon Sep 17 00:00:00 2001 From: haseeb Date: Fri, 15 Sep 2017 15:35:24 +0000 Subject: created services for keys --- changelogs/unreleased/35917_create_services_for_keys.yml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 changelogs/unreleased/35917_create_services_for_keys.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/35917_create_services_for_keys.yml b/changelogs/unreleased/35917_create_services_for_keys.yml new file mode 100644 index 00000000000..e7cad5a11d5 --- /dev/null +++ b/changelogs/unreleased/35917_create_services_for_keys.yml @@ -0,0 +1,4 @@ +--- +title: creation of keys moved to services +merge_request: 13331 +author: haseebeqx -- cgit v1.2.1 From b3d79b1ff4ad1e601e1e817e7ad8f446e60bfa59 Mon Sep 17 00:00:00 2001 From: "Vitaliy @blackst0ne Klachkov" Date: Sat, 16 Sep 2017 20:02:30 +1100 Subject: Replace the 'search.feature' spinach test with an rspec analog --- changelogs/unreleased/replace_search-feature.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/replace_search-feature.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/replace_search-feature.yml b/changelogs/unreleased/replace_search-feature.yml new file mode 100644 index 00000000000..487f602ba30 --- /dev/null +++ b/changelogs/unreleased/replace_search-feature.yml @@ -0,0 +1,5 @@ +--- +title: Replace the 'search.feature' spinach test with an rspec analog +merge_request: 14248 +author: Vitaliy @blackst0ne Klachkov +type: other -- cgit v1.2.1 From 9ddc62ccfc16f3d6cc5f6c6a8624c5f7b5067faf Mon Sep 17 00:00:00 2001 From: Phil Hughes Date: Sat, 16 Sep 2017 17:19:59 +0000 Subject: Fixed the new sidebars width when browser has scrollbars --- changelogs/unreleased/fix-sidebar-with-scrollbars.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/fix-sidebar-with-scrollbars.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/fix-sidebar-with-scrollbars.yml b/changelogs/unreleased/fix-sidebar-with-scrollbars.yml new file mode 100644 index 00000000000..e0b3851b97f --- /dev/null +++ b/changelogs/unreleased/fix-sidebar-with-scrollbars.yml @@ -0,0 +1,5 @@ +--- +title: Fixed the sidebar scrollbar overlapping links +merge_request: +author: +type: fixed -- cgit v1.2.1 From e6d5a6a370940d16891bb7e84e7b19bfab164c50 Mon Sep 17 00:00:00 2001 From: "Vitaliy @blackst0ne Klachkov" Date: Sun, 17 Sep 2017 17:12:03 +1100 Subject: Replace the 'project/archived.feature' spinach test with an rspec analog --- changelogs/unreleased/replace_project_archived-feature.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/replace_project_archived-feature.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/replace_project_archived-feature.yml b/changelogs/unreleased/replace_project_archived-feature.yml new file mode 100644 index 00000000000..d0697347aa0 --- /dev/null +++ b/changelogs/unreleased/replace_project_archived-feature.yml @@ -0,0 +1,5 @@ +--- +title: Replace the 'project/archived.feature' spinach test with an rspec analog +merge_request: 14322 +author: Vitaliy @blackst0ne Klachkov +type: other -- cgit v1.2.1 From b5a091e3a4c01374138b3b327ec8cde3c23bef69 Mon Sep 17 00:00:00 2001 From: "Vitaliy @blackst0ne Klachkov" Date: Mon, 18 Sep 2017 16:15:42 +1100 Subject: Replace the 'project/commits/revert.feature' spinach test with an rspec analog --- changelogs/unreleased/replace_project_commits_revert-feature.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelogs/unreleased/replace_project_commits_revert-feature.yml (limited to 'changelogs') diff --git a/changelogs/unreleased/replace_project_commits_revert-feature.yml b/changelogs/unreleased/replace_project_commits_revert-feature.yml new file mode 100644 index 00000000000..7fc9fcf3580 --- /dev/null +++ b/changelogs/unreleased/replace_project_commits_revert-feature.yml @@ -0,0 +1,5 @@ +--- +title: Replace the 'project/commits/revert.feature' spinach test with an rspec analog +merge_request: 14325 +author: Vitaliy @blackst0ne Klachkov +type: other -- cgit v1.2.1