From 24a5fe6b1497308832329ff0c1f31b309b3b0f96 Mon Sep 17 00:00:00 2001 From: Michel Engelen Date: Mon, 15 Jul 2019 06:10:32 +0000 Subject: Rename "discussions" to "threads" in docs --- doc/development/code_review.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'doc/development/code_review.md') diff --git a/doc/development/code_review.md b/doc/development/code_review.md index e60800f1ab7..35ce6b8cbe4 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -207,9 +207,9 @@ first time. - Extract unrelated changes and refactorings into future merge requests/issues. - Seek to understand the reviewer's perspective. - Try to respond to every comment. -- The merge request author resolves only the discussions they have fully - addressed. If there's an open reply, an open discussion, a suggestion, - a question, or anything else, the discussion should be left to be resolved +- The merge request author resolves only the threads they have fully + addressed. If there's an open reply, an open thread, a suggestion, + a question, or anything else, the thread should be left to be resolved by the reviewer. - Push commits based on earlier rounds of feedback as isolated commits to the branch. Do not squash until the branch is ready to merge. Reviewers should be -- cgit v1.2.1