From 05255631ae2dad3b22796343453bb3288ca3dbff Mon Sep 17 00:00:00 2001 From: Douglas Barbosa Alexandre Date: Mon, 24 Apr 2017 21:03:42 -0300 Subject: Cache labels at the same time we fetch them from the GH API --- lib/github/import.rb | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'lib/github') diff --git a/lib/github/import.rb b/lib/github/import.rb index ba30ea0e2cd..641147c40e4 100644 --- a/lib/github/import.rb +++ b/lib/github/import.rb @@ -95,10 +95,13 @@ module Github response.body.each do |raw| begin - label = Github::Representation::Label.new(raw) - next if project.labels.where(title: label.title).exists? + representation = Github::Representation::Label.new(raw) - project.labels.create!(title: label.title, color: label.color) + label = project.labels.find_or_create_by!(title: representation.title) do |label| + label.color = representation.color + end + + cached[:label_ids][label.title] = label.id rescue => e error(:label, label.url, e.message) end @@ -106,11 +109,6 @@ module Github url = response.rels[:next] end - - # Cache labels - project.labels.select(:id, :title).find_each do |label| - cached[:label_ids][label.title] = label.id - end end def fetch_milestones -- cgit v1.2.1