From 1502fed795979b19ca5366b688f07ffc22c79c99 Mon Sep 17 00:00:00 2001 From: Michael Alt Date: Sat, 21 Mar 2015 22:57:55 +0100 Subject: Faulty LDAP DN name escaping removed The Net::LDAP::Filter.escape function can not be used to escape the DN name because the backslash is required to escape special chars in the DN name. This leads to the error message "Access denied for your LDAP account." and prevents the user from logging in to gitlab. Example DN: CN=Test\, User,OU=Organization,DC=Company CN=Test User,OU=Organization,DC=Company http://www.ietf.org/rfc/rfc4514.txt --- lib/gitlab/ldap/person.rb | 1 - 1 file changed, 1 deletion(-) (limited to 'lib/gitlab/ldap/person.rb') diff --git a/lib/gitlab/ldap/person.rb b/lib/gitlab/ldap/person.rb index 3c426179375..b81f3e8e8f5 100644 --- a/lib/gitlab/ldap/person.rb +++ b/lib/gitlab/ldap/person.rb @@ -14,7 +14,6 @@ module Gitlab end def self.find_by_dn(dn, adapter) - dn = Net::LDAP::Filter.escape(dn) adapter.user('dn', dn) end -- cgit v1.2.1