From 2822526e7b996c90fb3bbd7c286c2777e5e37360 Mon Sep 17 00:00:00 2001 From: Kamil Trzcinski Date: Thu, 27 Oct 2016 12:34:09 +0100 Subject: Make retry_lock to not be infinite --- lib/gitlab/optimistic_locking.rb | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'lib') diff --git a/lib/gitlab/optimistic_locking.rb b/lib/gitlab/optimistic_locking.rb index 17010d73c57..879d46446b3 100644 --- a/lib/gitlab/optimistic_locking.rb +++ b/lib/gitlab/optimistic_locking.rb @@ -1,12 +1,16 @@ module Gitlab - class OptimisticLocking - def self.retry_lock(subject, &block) + module OptimisticLocking + extend self + + def retry_lock(subject, retries = 100, &block) loop do begin - subject.transaction do + ActiveRecord::Base.transaction do return block.call(subject) end rescue ActiveRecord::StaleObjectError + retries -= 1 + raise unless retries >= 0 subject.reload end end -- cgit v1.2.1