From 74399a90989e5caade1de1833a7f65cfbc070bcd Mon Sep 17 00:00:00 2001
From: Lin Jen-Shin <godfat@godfat.org>
Date: Fri, 24 May 2019 02:07:59 +0800
Subject: Show Test Automation Engineer for spec/feature as

reviewers.
---
 lib/gitlab/danger/helper.rb   |  4 +++-
 lib/gitlab/danger/teammate.rb | 27 ++++++++++++++++++++-------
 2 files changed, 23 insertions(+), 8 deletions(-)

(limited to 'lib')

diff --git a/lib/gitlab/danger/helper.rb b/lib/gitlab/danger/helper.rb
index 7effb802678..7a0fb419f8e 100644
--- a/lib/gitlab/danger/helper.rb
+++ b/lib/gitlab/danger/helper.rb
@@ -72,7 +72,8 @@ module Gitlab
       CATEGORY_LABELS = {
         docs: "~Documentation", # Docs are reviewed along DevOps stages, so don't need roulette for now.
         none: "",
-        qa: "~QA"
+        qa: "~QA",
+        test: "~test for `spec/features/*`"
       }.freeze
       CATEGORIES = {
         %r{\Adoc/} => :none, # To reinstate roulette for documentation, set to `:docs`.
@@ -104,6 +105,7 @@ module Gitlab
 
         %r{\A(ee/)?app/(?!assets|views)[^/]+} => :backend,
         %r{\A(ee/)?(bin|config|danger|generator_templates|lib|rubocop|scripts)/} => :backend,
+        %r{\A(ee/)?spec/features/} => :test,
         %r{\A(ee/)?spec/(?!javascripts|frontend)[^/]+} => :backend,
         %r{\A(ee/)?vendor/(?!assets)[^/]+} => :backend,
         %r{\A(ee/)?vendor/(languages\.yml|licenses\.csv)\z} => :backend,
diff --git a/lib/gitlab/danger/teammate.rb b/lib/gitlab/danger/teammate.rb
index c4e66da8ed1..b44f134f2c1 100644
--- a/lib/gitlab/danger/teammate.rb
+++ b/lib/gitlab/danger/teammate.rb
@@ -3,11 +3,12 @@
 module Gitlab
   module Danger
     class Teammate
-      attr_reader :name, :username, :projects
+      attr_reader :name, :username, :role, :projects
 
       def initialize(options = {})
         @username = options['username']
         @name = options['name'] || @username
+        @role = options['role']
         @projects = options['projects']
       end
 
@@ -20,20 +21,32 @@ module Gitlab
       end
 
       # Traintainers also count as reviewers
-      def reviewer?(project, category)
-        capabilities(project).include?("reviewer #{category}") || traintainer?(project, category)
+      def reviewer?(project, category, labels)
+        has_capability?(project, category, :reviewer, labels) ||
+          traintainer?(project, category, labels)
       end
 
-      def traintainer?(project, category)
-        capabilities(project).include?("trainee_maintainer #{category}")
+      def traintainer?(project, category, labels)
+        has_capability?(project, category, :trainee_maintainer, labels)
       end
 
-      def maintainer?(project, category)
-        capabilities(project).include?("maintainer #{category}")
+      def maintainer?(project, category, labels)
+        has_capability?(project, category, :maintainer, labels)
       end
 
       private
 
+      def has_capability?(project, category, kind, labels)
+        case category
+        when :test
+          area = role[/Test Automation Engineer, (\w+)/, 1]
+
+          area && labels.any?(area) if kind == :reviewer
+        else
+          capabilities(project).include?("#{kind} #{category}")
+        end
+      end
+
       def capabilities(project)
         Array(projects.fetch(project, []))
       end
-- 
cgit v1.2.1