From fcc20fde8346a9c2dd9e79ded2557c8058ac1e22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20Trzci=C5=84ski?= Date: Wed, 14 Aug 2019 11:09:11 +0200 Subject: Add `ci_dag_limit_needs` feature flag This makes to limit `needs:` to 5 by default. Allow to increase the limit to 50 with disable of FF. --- lib/gitlab/ci/pipeline/seed/build.rb | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/gitlab/ci/pipeline/seed/build.rb b/lib/gitlab/ci/pipeline/seed/build.rb index 32086735556..b0ce7457926 100644 --- a/lib/gitlab/ci/pipeline/seed/build.rb +++ b/lib/gitlab/ci/pipeline/seed/build.rb @@ -9,6 +9,10 @@ module Gitlab delegate :dig, to: :@attributes + # When the `ci_dag_limit_needs` is enabled it uses the lower limit + LOW_NEEDS_LIMIT = 5 + HARD_NEEDS_LIMIT = 50 + def initialize(pipeline, attributes, previous_stages) @pipeline = pipeline @attributes = attributes @@ -77,9 +81,15 @@ module Gitlab end def needs_errors - return unless Feature.enabled?(:ci_dag_support, @pipeline.project) return if @needs_attributes.nil? + if @needs_attributes.size > max_needs_allowed + return [ + "#{name}: one job can only need #{max_needs_allowed} others, but you have listed #{@needs_attributes.size}. " \ + "See needs keyword documentation for more details" + ] + end + @needs_attributes.flat_map do |need| result = @previous_stages.any? do |stage| stage.seeds_names.include?(need[:name]) @@ -88,6 +98,14 @@ module Gitlab "#{name}: needs '#{need[:name]}'" unless result end.compact end + + def max_needs_allowed + if Feature.enabled?(:ci_dag_limit_needs, @project, default_enabled: true) + LOW_NEEDS_LIMIT + else + HARD_NEEDS_LIMIT + end + end end end end -- cgit v1.2.1