From af7c98044e0c5809e2c8792b85ec8e2f14590a07 Mon Sep 17 00:00:00 2001
From: ddavison <ddavison@gitlab.com>
Date: Mon, 8 Jul 2019 16:06:11 -0700
Subject: Allow specificity for GKE Cluster Location

Use GCLOUD_REGION over GCLOUD_ZONE.
Using REGION over ZONE provides more of a
guarantee of cluster size, and dist-
ributes between a region's zones
---
 qa/qa/runtime/env.rb                |  4 ++--
 qa/qa/service/kubernetes_cluster.rb | 14 +++++++-------
 2 files changed, 9 insertions(+), 9 deletions(-)

(limited to 'qa')

diff --git a/qa/qa/runtime/env.rb b/qa/qa/runtime/env.rb
index 96f337dc081..39e3a4772ad 100644
--- a/qa/qa/runtime/env.rb
+++ b/qa/qa/runtime/env.rb
@@ -173,8 +173,8 @@ module QA
         ENV.fetch("GCLOUD_ACCOUNT_EMAIL")
       end
 
-      def gcloud_zone
-        ENV.fetch('GCLOUD_ZONE')
+      def gcloud_region
+        ENV.fetch('GCLOUD_REGION')
       end
 
       def has_gcloud_credentials?
diff --git a/qa/qa/service/kubernetes_cluster.rb b/qa/qa/service/kubernetes_cluster.rb
index 16a89591eb2..40263e94065 100644
--- a/qa/qa/service/kubernetes_cluster.rb
+++ b/qa/qa/service/kubernetes_cluster.rb
@@ -28,17 +28,17 @@ module QA
           create #{cluster_name}
           #{auth_options}
           --enable-basic-auth
-          --zone #{Runtime::Env.gcloud_zone}
+          --region #{Runtime::Env.gcloud_region}
           && gcloud container clusters
           get-credentials
-          --zone #{Runtime::Env.gcloud_zone}
+          --region #{Runtime::Env.gcloud_region}
           #{cluster_name}
         CMD
 
         @api_url = `kubectl config view --minify -o jsonpath='{.clusters[].cluster.server}'`
 
         @admin_user = "#{cluster_name}-admin"
-        master_auth = JSON.parse(`gcloud container clusters describe #{cluster_name} --zone #{Runtime::Env.gcloud_zone} --format 'json(masterAuth.username, masterAuth.password)'`)
+        master_auth = JSON.parse(`gcloud container clusters describe #{cluster_name} --region #{Runtime::Env.gcloud_region} --format 'json(masterAuth.username, masterAuth.password)'`)
         shell <<~CMD.tr("\n", ' ')
           kubectl config set-credentials #{@admin_user}
           --username #{master_auth['masterAuth']['username']}
@@ -66,10 +66,10 @@ module QA
       def remove!
         shell <<~CMD.tr("\n", ' ')
           gcloud container clusters delete
-          --zone #{Runtime::Env.gcloud_zone}
-	  #{cluster_name}
-	  --quiet --async
-	CMD
+          --region #{Runtime::Env.gcloud_region}
+          #{cluster_name}
+          --quiet --async
+        CMD
       end
 
       private
-- 
cgit v1.2.1