From e7b0fe36d78a4462baf623bda5d34089a19e6c23 Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Wed, 20 Dec 2017 17:26:21 +0800 Subject: It should escape spaces to %20 rather than + `CGI.escape` would escape spaces to +, which is fine in some cases, but doesn't work for git clone. --- qa/qa/git/repository.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'qa') diff --git a/qa/qa/git/repository.rb b/qa/qa/git/repository.rb index 59cd147e055..8f999511d58 100644 --- a/qa/qa/git/repository.rb +++ b/qa/qa/git/repository.rb @@ -23,7 +23,7 @@ module QA def password=(pass) @password = pass - @uri.password = CGI.escape(pass) + @uri.password = CGI.escape(pass).gsub('+', '%20') end def use_default_credentials -- cgit v1.2.1