From 916bb451c1423687beb6b25889446f5b7c696c40 Mon Sep 17 00:00:00 2001 From: Walmyr Lima Date: Mon, 3 Jun 2019 12:52:21 +0200 Subject: De-quarantine e2e test for issue suggestions According to https://bit.ly/2JTPCcF Now that https://gitlab.com/gitlab-org/gitlab-ce/issues/60355 is closed we can de-quarantine this test. --- qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'qa') diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb index f97b0e56ca2..7e8b42e286f 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb @@ -1,8 +1,7 @@ # frozen_string_literal: true module QA - # Failure issue: https://gitlab.com/gitlab-org/quality/staging/issues/53 - context 'Plan', :quarantine do + context 'Plan' do describe 'issue suggestions' do let(:issue_title) { 'Issue Lists are awesome' } -- cgit v1.2.1 From e04fc982af5b5677519efe669b5fd295315a7202 Mon Sep 17 00:00:00 2001 From: Walmyr Lima Date: Mon, 3 Jun 2019 12:55:35 +0200 Subject: Update e2e test with more explicit methods This goes in accordance with https://bit.ly/2Z1RdjZ --- .../specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'qa') diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb index 7e8b42e286f..530fc684437 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb @@ -9,12 +9,12 @@ module QA Runtime::Browser.visit(:gitlab, Page::Main::Login) Page::Main::Login.perform(&:sign_in_using_credentials) - project = Resource::Project.fabricate! do |resource| + project = Resource::Project.fabricate_via_api! do |resource| resource.name = 'project-for-issue-suggestions' resource.description = 'project for issue suggestions' end - Resource::Issue.fabricate! do |issue| + Resource::Issue.fabricate_via_browser_ui! do |issue| issue.title = issue_title issue.project = project end -- cgit v1.2.1