From d048c8fe43950438d4168f1a0750f6197d1252a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= Date: Fri, 3 Nov 2017 17:00:49 +0100 Subject: Use the --parallel Rubocop flag in the static-analysis and improve the job MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Rémy Coutable --- scripts/static-analysis | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) (limited to 'scripts') diff --git a/scripts/static-analysis b/scripts/static-analysis index aeefb2bc96f..51a2fd81a79 100755 --- a/scripts/static-analysis +++ b/scripts/static-analysis @@ -11,31 +11,40 @@ tasks = [ %w[bundle exec rake brakeman], %w[bundle exec license_finder], %w[yarn run eslint], - %w[bundle exec rubocop --require rubocop-rspec], + %w[bundle exec rubocop --parallel], %w[scripts/lint-conflicts.sh], %w[bundle exec rake gettext:lint], %w[scripts/lint-changelog-yaml] ] failed_tasks = tasks.reduce({}) do |failures, task| - output, status = Gitlab::Popen.popen(task) + start = Time.now + puts + puts "$ #{task.join(' ')}" - puts "Running: #{task.join(' ')}" - puts output + output, status = Gitlab::Popen.popen(task) + puts "==> Finished in #{Time.now - start} seconds" + puts failures[task.join(' ')] = output unless status.zero? failures end +puts +puts '===================================================' +puts +puts + if failed_tasks.empty? puts 'All static analyses passed successfully.' else - puts "\n===================================================\n\n" - puts "Some static analyses failed:" + puts 'Some static analyses failed:' failed_tasks.each do |failed_task, output| - puts "\n**** #{failed_task} failed with the following error:\n\n" + puts + puts "**** #{failed_task} failed with the following error:" + puts puts output end -- cgit v1.2.1