From 97c4a1dceab97cd1388f5bdb1d3f4fd3d228f94b Mon Sep 17 00:00:00 2001 From: Robert Speicher Date: Wed, 20 Jul 2016 16:45:19 -0600 Subject: Refactor Issues::BulkUpdateService spec - Create fewer Issue objects; 2 is as good as 5 for these cases. This gives us a nice little speed improvement. - Don't `describe` Symbols. - Simplify object creation. - Lessen "mystery guest" antipattern --- spec/factories/issues.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'spec/factories/issues.rb') diff --git a/spec/factories/issues.rb b/spec/factories/issues.rb index e72aa9479b7..2c0a2dd94ca 100644 --- a/spec/factories/issues.rb +++ b/spec/factories/issues.rb @@ -18,5 +18,15 @@ FactoryGirl.define do factory :closed_issue, traits: [:closed] factory :reopened_issue, traits: [:reopened] + + factory :labeled_issue do + transient do + labels [] + end + + after(:create) do |issue, evaluator| + issue.update_attributes(labels: evaluator.labels) + end + end end end -- cgit v1.2.1