From 35354826b11c69b1fc69100838727d473dfd9e9d Mon Sep 17 00:00:00 2001 From: Grzegorz Bizon Date: Wed, 21 Feb 2018 14:55:35 +0100 Subject: Improve pipeline expressions specs and freeze constants --- .../gitlab/ci/pipeline/expression/statement_spec.rb | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) (limited to 'spec/lib/gitlab/ci/pipeline/expression/statement_spec.rb') diff --git a/spec/lib/gitlab/ci/pipeline/expression/statement_spec.rb b/spec/lib/gitlab/ci/pipeline/expression/statement_spec.rb index 7f5f55660be..3d714a64a12 100644 --- a/spec/lib/gitlab/ci/pipeline/expression/statement_spec.rb +++ b/spec/lib/gitlab/ci/pipeline/expression/statement_spec.rb @@ -29,11 +29,22 @@ describe Gitlab::Ci::Pipeline::Expression::Statement do end context 'when expression grammar is correct' do - let(:text) { '$VAR == "value"' } + context 'when using an operator' do + let(:text) { '$VAR == "value"' } - it 'returns a reverse descent parse tree when using operator' do - expect(subject.parse_tree) - .to be_a Gitlab::Ci::Pipeline::Expression::Equals + it 'returns a reverse descent parse tree' do + expect(subject.parse_tree) + .to be_a Gitlab::Ci::Pipeline::Expression::Equals + end + end + + context 'when using a single token' do + let(:text) { '$VARIABLE' } + + it 'returns a single token instance' do + expect(subject.parse_tree) + .to be_a Gitlab::Ci::Pipeline::Expression::Variable + end end end end -- cgit v1.2.1