From cce8cf03d3bebe8b05375e4db0004328f84b28a2 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 6 Apr 2020 06:09:19 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- spec/models/jira_import_state_spec.rb | 149 ++++++++++++++++++++++++++++++++++ spec/models/project_spec.rb | 29 +++++++ 2 files changed, 178 insertions(+) create mode 100644 spec/models/jira_import_state_spec.rb (limited to 'spec/models') diff --git a/spec/models/jira_import_state_spec.rb b/spec/models/jira_import_state_spec.rb new file mode 100644 index 00000000000..f75a17f71b2 --- /dev/null +++ b/spec/models/jira_import_state_spec.rb @@ -0,0 +1,149 @@ +# frozen_string_literal: true + +require 'spec_helper' + +describe JiraImportState do + describe "associations" do + it { is_expected.to belong_to(:project) } + it { is_expected.to belong_to(:user) } + it { is_expected.to belong_to(:label) } + end + + describe 'modules' do + subject { described_class } + + it { is_expected.to include_module(AfterCommitQueue) } + end + + describe 'validations' do + it { is_expected.to validate_presence_of(:project) } + it { is_expected.to validate_presence_of(:jira_project_key) } + it { is_expected.to validate_presence_of(:jira_project_name) } + it { is_expected.to validate_presence_of(:jira_project_xid) } + + context 'when trying to run multiple imports' do + let(:project) { create(:project) } + + context 'when project has an initial jira_import' do + let!(:jira_import) { create(:jira_import_state, project: project)} + + it_behaves_like 'multiple running imports not allowed' + end + + context 'when project has a scheduled jira_import' do + let!(:jira_import) { create(:jira_import_state, :scheduled, project: project)} + + it_behaves_like 'multiple running imports not allowed' + end + + context 'when project has a started jira_import' do + let!(:jira_import) { create(:jira_import_state, :started, project: project)} + + it_behaves_like 'multiple running imports not allowed' + end + + context 'when project has a failed jira_import' do + let!(:jira_import) { create(:jira_import_state, :failed, project: project)} + + it 'returns valid' do + new_import = build(:jira_import_state, project: project) + + expect(new_import).to be_valid + expect(new_import.errors[:project]).to be_empty + end + end + + context 'when project has a finished jira_import' do + let!(:jira_import) { create(:jira_import_state, :finished, project: project)} + + it 'returns valid' do + new_import = build(:jira_import_state, project: project) + + expect(new_import).to be_valid + expect(new_import.errors[:project]).to be_empty + end + end + end + end + + describe '#in_progress?' do + context 'statuses that return in progress' do + it_behaves_like 'in progress', :scheduled + it_behaves_like 'in progress', :started + end + + context 'statuses that return not in progress' do + it_behaves_like 'not in progress', :initial + it_behaves_like 'not in progress', :failed + it_behaves_like 'not in progress', :finished + end + end + + describe 'states transition flow' do + let(:project) { create(:project) } + + context 'when jira import is in initial state' do + let!(:jira_import) { build(:jira_import_state, project: project)} + + it_behaves_like 'can transition', [:schedule, :do_fail] + it_behaves_like 'cannot transition', [:start, :finish] + end + + context 'when jira import is in scheduled state' do + let!(:jira_import) { build(:jira_import_state, :scheduled, project: project)} + + it_behaves_like 'can transition', [:start, :do_fail] + it_behaves_like 'cannot transition', [:finish] + end + + context 'when jira import is in started state' do + let!(:jira_import) { build(:jira_import_state, :started, project: project)} + + it_behaves_like 'can transition', [:finish, :do_fail] + it_behaves_like 'cannot transition', [:schedule] + end + + context 'when jira import is in failed state' do + let!(:jira_import) { build(:jira_import_state, :failed, project: project)} + + it_behaves_like 'cannot transition', [:schedule, :finish, :do_fail] + end + + context 'when jira import is in finished state' do + let!(:jira_import) { build(:jira_import_state, :finished, project: project)} + + it_behaves_like 'cannot transition', [:schedule, :do_fail, :start] + end + + context 'after transition to scheduled' do + let!(:jira_import) { build(:jira_import_state, project: project)} + + it 'triggers the import job' do + expect(Gitlab::JiraImport::Stage::StartImportWorker).to receive(:perform_async).and_return('some-job-id') + + jira_import.schedule + + expect(jira_import.jid).to eq('some-job-id') + end + end + + context 'after transition to finished' do + let!(:jira_import) { build(:jira_import_state, :started, jid: 'some-other-jid', project: project)} + + it 'triggers the import job' do + jira_import.finish + + expect(jira_import.jid).to be_nil + end + + it 'triggers the import job' do + jira_import.update!(status: :scheduled) + + jira_import.finish + + expect(jira_import.status).to eq('scheduled') + expect(jira_import.jid).to eq('some-other-jid') + end + end + end +end diff --git a/spec/models/project_spec.rb b/spec/models/project_spec.rb index 1b12550ebac..0904ebca670 100644 --- a/spec/models/project_spec.rb +++ b/spec/models/project_spec.rb @@ -110,6 +110,7 @@ describe Project do it { is_expected.to have_many(:source_pipelines) } it { is_expected.to have_many(:prometheus_alert_events) } it { is_expected.to have_many(:self_managed_prometheus_alert_events) } + it { is_expected.to have_many(:jira_imports) } it_behaves_like 'model with repository' do let_it_be(:container) { create(:project, :repository, path: 'somewhere') } @@ -5987,6 +5988,34 @@ describe Project do end end + describe '#latest_jira_import' do + let_it_be(:project) { create(:project) } + context 'when no jira imports' do + it 'returns nil' do + expect(project.latest_jira_import).to be nil + end + end + + context 'when single jira import' do + let!(:jira_import1) { create(:jira_import_state, project: project) } + + it 'returns the jira import' do + expect(project.latest_jira_import).to eq(jira_import1) + end + end + + context 'when multiple jira imports' do + let!(:jira_import1) { create(:jira_import_state, :finished, created_at: 1.day.ago, project: project) } + let!(:jira_import2) { create(:jira_import_state, :failed, created_at: 2.days.ago, project: project) } + let!(:jira_import3) { create(:jira_import_state, :started, created_at: 3.days.ago, project: project) } + + it 'returns latest jira import by created_at' do + expect(project.jira_imports.pluck(:id)).to eq([jira_import3.id, jira_import2.id, jira_import1.id]) + expect(project.latest_jira_import).to eq(jira_import1) + end + end + end + def finish_job(export_job) export_job.start export_job.finish -- cgit v1.2.1