From a43ab8d6a430014e875deb3bff3fd8d8da256747 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Etienne=20Baqu=C3=A9?= <ebaque@gitlab.com>
Date: Tue, 3 Sep 2019 09:38:59 +0000
Subject: Added relationships between Release and Milestone

Modified schema via migrations.
Added one-to-one relationship between the two models.
Added changelog file
---
 spec/services/releases/create_service_spec.rb | 62 +++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

(limited to 'spec/services/releases/create_service_spec.rb')

diff --git a/spec/services/releases/create_service_spec.rb b/spec/services/releases/create_service_spec.rb
index e26676cdd55..5c9d6537df1 100644
--- a/spec/services/releases/create_service_spec.rb
+++ b/spec/services/releases/create_service_spec.rb
@@ -72,6 +72,15 @@ describe Releases::CreateService do
         expect(project.releases.find_by(tag: tag_name).description).to eq(description)
       end
     end
+
+    context 'when a passed-in milestone does not exist for this project' do
+      it 'raises an error saying the milestone is inexistent' do
+        service = described_class.new(project, user, params.merge!({ milestone: 'v111.0' }))
+        result = service.execute
+        expect(result[:status]).to eq(:error)
+        expect(result[:message]).to eq('Milestone does not exist')
+      end
+    end
   end
 
   describe '#find_or_build_release' do
@@ -80,5 +89,58 @@ describe Releases::CreateService do
 
       expect(project.releases.count).to eq(0)
     end
+
+    context 'when existing milestone is passed in' do
+      let(:title) { 'v1.0' }
+      let(:milestone) { create(:milestone, :active, project: project, title: title) }
+      let(:params_with_milestone) { params.merge!({ milestone: title }) }
+
+      it 'creates a release and ties this milestone to it' do
+        service = described_class.new(milestone.project, user, params_with_milestone)
+        result = service.execute
+
+        expect(project.releases.count).to eq(1)
+        expect(result[:status]).to eq(:success)
+
+        release = project.releases.last
+
+        expect(release.milestone).to eq(milestone)
+      end
+
+      context 'when another release was previously created with that same milestone linked' do
+        it 'also creates another release tied to that same milestone' do
+          other_release = create(:release, milestone: milestone, project: project, tag: 'v1.0')
+          service = described_class.new(milestone.project, user, params_with_milestone)
+          service.execute
+          release = project.releases.last
+
+          expect(release.milestone).to eq(milestone)
+          expect(other_release.milestone).to eq(milestone)
+          expect(release.id).not_to eq(other_release.id)
+        end
+      end
+    end
+
+    context 'when no milestone is passed in' do
+      it 'creates a release without a milestone tied to it' do
+        expect(params.key? :milestone).to be_falsey
+        service.execute
+        release = project.releases.last
+        expect(release.milestone).to be_nil
+      end
+
+      it 'does not create any new MilestoneRelease object' do
+        expect { service.execute }.not_to change { MilestoneRelease.count }
+      end
+    end
+
+    context 'when an empty value is passed as a milestone' do
+      it 'creates a release without a milestone tied to it' do
+        service = described_class.new(project, user, params.merge!({ milestone: '' }))
+        service.execute
+        release = project.releases.last
+        expect(release.milestone).to be_nil
+      end
+    end
   end
 end
-- 
cgit v1.2.1