From ad44af2faaaa872ee30922699f66ac78fa402336 Mon Sep 17 00:00:00 2001 From: James Lopez Date: Fri, 16 Jun 2017 15:14:46 +0200 Subject: fixed specs --- spec/services/emails/create_service_spec.rb | 2 +- spec/services/emails/destroy_service_spec.rb | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) (limited to 'spec/services') diff --git a/spec/services/emails/create_service_spec.rb b/spec/services/emails/create_service_spec.rb index 7874da88665..9981f5fcc2b 100644 --- a/spec/services/emails/create_service_spec.rb +++ b/spec/services/emails/create_service_spec.rb @@ -19,7 +19,7 @@ describe Emails::CreateService, services: true do end it 'does not create an email if the user has no permissions' do - expect { described_class.new(create(:user), user, opts).execute }.not_to change { Email.count } + expect { described_class.new(create(:user), user, opts).execute }.to raise_error(Gitlab::Access::AccessDeniedError) end it 'creates an email if we skip authorization' do diff --git a/spec/services/emails/destroy_service_spec.rb b/spec/services/emails/destroy_service_spec.rb index 186726951f9..6db050148cb 100644 --- a/spec/services/emails/destroy_service_spec.rb +++ b/spec/services/emails/destroy_service_spec.rb @@ -12,12 +12,14 @@ describe Emails::DestroyService, services: true do end it 'does not remove an email if the user has no permissions' do - expect { described_class.new(create(:user), user, opts).execute }.not_to change { Email.count } + expect do + described_class.new(create(:user), user, email: email.email).execute + end.to raise_error(Gitlab::Access::AccessDeniedError) end it 'removes an email if we skip authorization' do expect do - described_class.new(create(:user), user, opts).execute(skip_authorization: true) + described_class.new(create(:user), user, email: email.email).execute(skip_authorization: true) end.to change { Email.count }.by(-1) end end -- cgit v1.2.1