From 5c828f39d8074c9f91e9034ddac860834fbc7177 Mon Sep 17 00:00:00 2001 From: John Cai Date: Tue, 4 Jun 2019 12:07:10 -0700 Subject: Fix null source_project_id in pool_repositories Due to a bug, some pool_repositories in production have a null source_project_id column. This migration aims to fix those rows. --- .../fix_pool_repository_source_project_id_spec.rb | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 spec/migrations/fix_pool_repository_source_project_id_spec.rb (limited to 'spec') diff --git a/spec/migrations/fix_pool_repository_source_project_id_spec.rb b/spec/migrations/fix_pool_repository_source_project_id_spec.rb new file mode 100644 index 00000000000..8ddee9bb575 --- /dev/null +++ b/spec/migrations/fix_pool_repository_source_project_id_spec.rb @@ -0,0 +1,29 @@ +# frozen_string_literal: true + +require 'spec_helper' +require Rails.root.join('db', 'migrate', '20190604184643_fix_pool_repository_source_project_id.rb') + +describe FixPoolRepositorySourceProjectId, :migration do + let(:projects) { table(:projects) } + let(:pool_repositories) { table(:pool_repositories) } + let(:shards) { table(:shards) } + + it 'fills in source_project_ids' do + shard = shards.create!(name: 'default') + + # gitaly is a project with a pool repository that has a source_project_id + gitaly = projects.create!(name: 'gitaly', path: 'gitlab-org/gitaly', namespace_id: 1) + pool_repository = pool_repositories.create(shard_id: shard.id, source_project_id: gitaly.id) + gitaly.update_column(:pool_repository_id, pool_repository.id) + + # gitlab is a project with a pool repository that's missing a source_project_id + pool_repository_without_source_project = pool_repositories.create(shard_id: shard.id, source_project_id: nil) + gitlab = projects.create!(name: 'gitlab', path: 'gitlab-org/gitlab-ce', namespace_id: 1, pool_repository_id: pool_repository_without_source_project.id) + projects.create!(name: 'gitlab-fork-1', path: 'my-org-1/gitlab-ce', namespace_id: 1, pool_repository_id: pool_repository_without_source_project.id) + + migrate! + + expect(pool_repositories.find(pool_repository_without_source_project.id).source_project_id).to eq(gitlab.id) + expect(pool_repositories.find(pool_repository.id).source_project_id).to eq(gitaly.id) + end +end -- cgit v1.2.1