From 9fc9ab2ba2b0db05f6365054aa3bddcda3c7333d Mon Sep 17 00:00:00 2001
From: Ash McKenzie <amckenzie@gitlab.com>
Date: Fri, 6 Sep 2019 11:21:53 +0000
Subject: Add new GitlabDanger class

This class encapsulates our use of the Danger gem.
---
 spec/lib/gitlab/danger/helper_spec.rb | 52 ++++++++++++++++++++++--
 spec/lib/gitlab_danger_spec.rb        | 76 +++++++++++++++++++++++++++++++++++
 2 files changed, 125 insertions(+), 3 deletions(-)
 create mode 100644 spec/lib/gitlab_danger_spec.rb

(limited to 'spec')

diff --git a/spec/lib/gitlab/danger/helper_spec.rb b/spec/lib/gitlab/danger/helper_spec.rb
index 710564b7540..1b4d366ce7b 100644
--- a/spec/lib/gitlab/danger/helper_spec.rb
+++ b/spec/lib/gitlab/danger/helper_spec.rb
@@ -11,16 +11,62 @@ describe Gitlab::Danger::Helper do
   class FakeDanger
     include Gitlab::Danger::Helper
 
-    attr_reader :git
+    attr_reader :git, :gitlab
 
-    def initialize(git:)
+    def initialize(git:, gitlab:)
       @git = git
+      @gitlab = gitlab
     end
   end
 
   let(:fake_git) { double('fake-git') }
 
-  subject(:helper) { FakeDanger.new(git: fake_git) }
+  let(:mr_author) { nil }
+  let(:fake_gitlab) { double('fake-gitlab', mr_author: mr_author) }
+
+  subject(:helper) { FakeDanger.new(git: fake_git, gitlab: fake_gitlab) }
+
+  describe '#gitlab_helper' do
+    context 'when gitlab helper is not available' do
+      let(:fake_gitlab) { nil }
+
+      it 'returns nil' do
+        expect(helper.gitlab_helper).to be_nil
+      end
+    end
+
+    context 'when gitlab helper is available' do
+      it 'returns the gitlab helper' do
+        expect(helper.gitlab_helper).to eq(fake_gitlab)
+      end
+    end
+  end
+
+  describe '#release_automation?' do
+    context 'when gitlab helper is not available' do
+      it 'returns false' do
+        expect(helper.release_automation?).to be_falsey
+      end
+    end
+
+    context 'when gitlab helper is available' do
+      context "but the MR author isn't the RELEASE_TOOLS_BOT" do
+        let(:mr_author) { 'johnmarston' }
+
+        it 'returns false' do
+          expect(helper.release_automation?).to be_falsey
+        end
+      end
+
+      context 'and the MR author is the RELEASE_TOOLS_BOT' do
+        let(:mr_author) { described_class::RELEASE_TOOLS_BOT }
+
+        it 'returns true' do
+          expect(helper.release_automation?).to be_truthy
+        end
+      end
+    end
+  end
 
   describe '#all_changed_files' do
     subject { helper.all_changed_files }
diff --git a/spec/lib/gitlab_danger_spec.rb b/spec/lib/gitlab_danger_spec.rb
new file mode 100644
index 00000000000..623ac20fa7c
--- /dev/null
+++ b/spec/lib/gitlab_danger_spec.rb
@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe GitlabDanger do
+  let(:gitlab_danger_helper) { nil }
+
+  subject { described_class.new(gitlab_danger_helper) }
+
+  describe '.local_warning_message' do
+    it 'returns an informational message with rules that can run' do
+      expect(described_class.local_warning_message).to eq('==> Only the following Danger rules can be run locally: changes_size, gemfile, documentation, frozen_string, duplicate_yarn_dependencies, prettier, eslint, database')
+    end
+  end
+
+  describe '.success_message' do
+    it 'returns an informational success message' do
+      expect(described_class.success_message).to eq('==> No Danger rule violations!')
+    end
+  end
+
+  describe '#rule_names' do
+    context 'when running locally' do
+      it 'returns local only rules' do
+        expect(subject.rule_names).to eq(described_class::LOCAL_RULES)
+      end
+    end
+
+    context 'when running under CI' do
+      let(:gitlab_danger_helper) { double('danger_gitlab_helper') }
+
+      it 'returns all rules' do
+        expect(subject.rule_names).to eq(described_class::LOCAL_RULES | described_class::CI_ONLY_RULES)
+      end
+    end
+  end
+
+  describe '#html_link' do
+    context 'when running locally' do
+      it 'returns the same string' do
+        str = 'something'
+
+        expect(subject.html_link(str)).to eq(str)
+      end
+    end
+
+    context 'when running under CI' do
+      let(:gitlab_danger_helper) { double('danger_gitlab_helper') }
+
+      it 'returns a HTML link formatted version of the string' do
+        str = 'something'
+        html_formatted_str = %Q{<a href="#{str}">#{str}</a>}
+
+        expect(gitlab_danger_helper).to receive(:html_link).with(str).and_return(html_formatted_str)
+
+        expect(subject.html_link(str)).to eq(html_formatted_str)
+      end
+    end
+  end
+
+  describe '#ci?' do
+    context 'when gitlab_danger_helper is not available' do
+      it 'returns false' do
+        expect(subject.ci?).to be_falsey
+      end
+    end
+
+    context 'when gitlab_danger_helper is available' do
+      let(:gitlab_danger_helper) { double('danger_gitlab_helper') }
+
+      it 'returns true' do
+        expect(subject.ci?).to be_truthy
+      end
+    end
+  end
+end
-- 
cgit v1.2.1