From ddafea060d4b607cd3f5c29e947cdbf6483dcd5d Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Sun, 23 Oct 2016 16:46:21 -0700 Subject: Fix bug where labels would be assigned to issues that were moved If you attempt to move an issue from one project to another and leave labels blank, LabelsFinder would assign all labels in the new project to that issue. The issue is that :title is passed along to the Finder, but since it appears empty no filtering is done. As a result, all labels in the group are returned. This fix handles that case. Closes #23668 --- spec/finders/labels_finder_spec.rb | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'spec') diff --git a/spec/finders/labels_finder_spec.rb b/spec/finders/labels_finder_spec.rb index 27acc464ea2..114399ea3dc 100644 --- a/spec/finders/labels_finder_spec.rb +++ b/spec/finders/labels_finder_spec.rb @@ -64,6 +64,12 @@ describe LabelsFinder do expect(finder.execute).to eq [group_label_2] end + + it 'returns no labels if empty titles are supplied' do + finder = described_class.new(user, title: []) + + expect(finder.execute).to be_empty + end end end end -- cgit v1.2.1