require 'rails_helper' describe 'Merge request > User sees merge widget', :js do include ProjectForksHelper include TestReportsHelper let(:project) { create(:project, :repository) } let(:project_only_mwps) { create(:project, :repository, only_allow_merge_if_pipeline_succeeds: true) } let(:user) { project.creator } let(:merge_request) { create(:merge_request, source_project: project) } let(:merge_request_in_only_mwps_project) { create(:merge_request, source_project: project_only_mwps) } before do project.add_maintainer(user) project_only_mwps.add_maintainer(user) sign_in(user) end context 'new merge request' do before do visit project_new_merge_request_path( project, merge_request_source_branch: 'feature', merge_request: { source_project_id: project.id, target_project_id: project.id, target_branch: 'master' }) end it 'shows widget status after creating new merge request' do click_button 'Submit merge request' wait_for_requests expect(page).to have_selector('.accept-merge-request') expect(find('.accept-merge-request')['disabled']).not_to be(true) end end context 'view merge request' do let!(:environment) { create(:environment, project: project) } let(:sha) { project.commit(merge_request.source_branch).sha } let(:pipeline) { create(:ci_pipeline_without_jobs, status: 'success', sha: sha, project: project, ref: merge_request.source_branch) } let(:build) { create(:ci_build, :success, pipeline: pipeline) } let!(:deployment) do create(:deployment, environment: environment, ref: merge_request.source_branch, deployable: build, sha: sha) end before do merge_request.update!(head_pipeline: pipeline) visit project_merge_request_path(project, merge_request) end it 'shows environments link' do wait_for_requests page.within('.js-pre-merge-deploy') do expect(page).to have_content("Deployed to #{environment.name}") expect(find('.js-deploy-url')[:href]).to include(environment.formatted_external_url) end end it 'shows green accept merge request button' do # Wait for the `ci_status` and `merge_check` requests wait_for_requests expect(page).to have_selector('.accept-merge-request') expect(find('.accept-merge-request')['disabled']).not_to be(true) end it 'allows me to merge, see cherry-pick modal and load branches list' do wait_for_requests click_button 'Merge' wait_for_requests click_link 'Cherry-pick' page.find('.js-project-refs-dropdown').click wait_for_requests expect(page.all('.js-cherry-pick-form .dropdown-content li').size).to be > 1 end end context 'view merge request with external CI service' do before do create(:service, project: project, active: true, type: 'CiService', category: 'ci') visit project_merge_request_path(project, merge_request) end it 'has danger button while waiting for external CI status' do # Wait for the `ci_status` and `merge_check` requests wait_for_requests expect(page).to have_selector('.accept-merge-request.btn-danger') end end context 'view merge request with failed GitLab CI pipelines' do before do commit_status = create(:commit_status, project: project, status: 'failed') pipeline = create(:ci_pipeline, project: project, sha: merge_request.diff_head_sha, ref: merge_request.source_branch, status: 'failed', statuses: [commit_status], head_pipeline_of: merge_request) create(:ci_build, :pending, pipeline: pipeline) visit project_merge_request_path(project, merge_request) end it 'has danger button when not succeeded' do # Wait for the `ci_status` and `merge_check` requests wait_for_requests expect(page).to have_selector('.accept-merge-request.btn-danger') end end context 'when merge request is in the blocked pipeline state' do before do create( :ci_pipeline, project: project, sha: merge_request.diff_head_sha, ref: merge_request.source_branch, status: :manual, head_pipeline_of: merge_request) visit project_merge_request_path(project, merge_request) end it 'shows information about blocked pipeline' do expect(page).to have_content("Pipeline blocked") expect(page).to have_content( "The pipeline for this merge request requires a manual action") expect(page).to have_css('.ci-status-icon-manual') end end context 'view merge request with MWBS button' do before do commit_status = create(:commit_status, project: project, status: 'pending') pipeline = create(:ci_pipeline, project: project, sha: merge_request.diff_head_sha, ref: merge_request.source_branch, status: 'pending', statuses: [commit_status], head_pipeline_of: merge_request) create(:ci_build, :pending, pipeline: pipeline) visit project_merge_request_path(project, merge_request) end it 'has info button when MWBS button' do # Wait for the `ci_status` and `merge_check` requests wait_for_requests expect(page).to have_selector('.accept-merge-request.btn-info') end end context 'view merge request where project has CI set up but no CI status' do before do pipeline = create(:ci_pipeline, project: project, sha: merge_request.diff_head_sha, ref: merge_request.source_branch) create(:ci_build, pipeline: pipeline) visit project_merge_request_path(project, merge_request) end it 'has pipeline error text' do # Wait for the `ci_status` and `merge_check` requests wait_for_requests expect(page).to have_text(%r{Could not retrieve the pipeline status\. For troubleshooting steps, read the documentation\.}) end end context 'view merge request in project with only-mwps setting enabled but no CI is set up' do before do visit project_merge_request_path(project_only_mwps, merge_request_in_only_mwps_project) end it 'should be allowed to merge' do # Wait for the `ci_status` and `merge_check` requests wait_for_requests expect(page).to have_selector('.accept-merge-request') expect(find('.accept-merge-request')['disabled']).not_to be(true) end end context 'view merge request with MWPS enabled but automatically merge fails' do before do merge_request.update( merge_when_pipeline_succeeds: true, merge_user: merge_request.author, merge_error: 'Something went wrong' ) visit project_merge_request_path(project, merge_request) end it 'shows information about the merge error' do # Wait for the `ci_status` and `merge_check` requests wait_for_requests page.within('.mr-widget-body') do expect(page).to have_content('Something went wrong') end end end context 'view merge request with MWPS enabled but automatically merge fails' do before do merge_request.update( merge_when_pipeline_succeeds: true, merge_user: merge_request.author, merge_error: 'Something went wrong' ) visit project_merge_request_path(project, merge_request) end it 'shows information about the merge error' do # Wait for the `ci_status` and `merge_check` requests wait_for_requests page.within('.mr-widget-body') do expect(page).to have_content('Something went wrong') end end end context 'view merge request where fast-forward merge is not possible' do before do project.update(merge_requests_ff_only_enabled: true) merge_request.update( merge_user: merge_request.author, merge_status: :cannot_be_merged ) visit project_merge_request_path(project, merge_request) end it 'shows information about the merge error' do # Wait for the `ci_status` and `merge_check` requests wait_for_requests page.within('.mr-widget-body') do expect(page).to have_content('Fast-forward merge is not possible') end end end context 'merge error' do before do allow_any_instance_of(Repository).to receive(:merge).and_return(false) visit project_merge_request_path(project, merge_request) end it 'updates the MR widget' do click_button 'Merge' page.within('.mr-widget-body') do expect(page).to have_content('Conflicts detected during merge') end end end context 'user can merge into source project but cannot push to fork', :js do let(:fork_project) { create(:project, :public, :repository) } let(:user2) { create(:user) } before do project.add_maintainer(user2) sign_out(:user) sign_in(user2) merge_request.update(target_project: fork_project) visit project_merge_request_path(project, merge_request) end it 'user can merge into the source project' do expect(page).to have_button('Merge', disabled: false) end it 'user cannot remove source branch' do expect(page).not_to have_field('remove-source-branch-input') end end context 'user cannot merge project and cannot push to fork', :js do let(:forked_project) { fork_project(project, nil, repository: true) } let(:user2) { create(:user) } before do project.add_developer(user2) sign_out(:user) sign_in(user2) merge_request.update( source_project: forked_project, target_project: project, merge_params: { 'force_remove_source_branch' => '1' } ) visit project_merge_request_path(project, merge_request) end it 'user cannot remove source branch' do expect(page).not_to have_field('remove-source-branch-input') expect(page).to have_content('Removes source branch') end end context 'ongoing merge process' do it 'shows Merging state' do allow_any_instance_of(MergeRequest).to receive(:merge_ongoing?).and_return(true) visit project_merge_request_path(project, merge_request) wait_for_requests expect(page).not_to have_button('Merge') expect(page).to have_content('This merge request is in the process of being merged') end end context 'when merge request has test reports' do let!(:head_pipeline) do create(:ci_pipeline, :success, project: project, ref: merge_request.source_branch, sha: merge_request.diff_head_sha) end let!(:build) { create(:ci_build, :success, pipeline: head_pipeline, project: project) } before do merge_request.update!(head_pipeline_id: head_pipeline.id) end context 'when result has not been parsed yet' do let!(:job_artifact) { create(:ci_job_artifact, :junit, job: build, project: project) } before do visit project_merge_request_path(project, merge_request) end it 'shows parsing status' do expect(page).to have_content('Test summary results are being parsed') end end context 'when result has already been parsed' do context 'when JUnit xml is correctly formatted' do let!(:job_artifact) { create(:ci_job_artifact, :junit, job: build, project: project) } before do allow_any_instance_of(MergeRequest).to receive(:compare_test_reports).and_return(compared_data) visit project_merge_request_path(project, merge_request) end it 'shows parsed results' do expect(page).to have_content('Test summary contained') end end context 'when JUnit xml is corrupted' do let!(:job_artifact) { create(:ci_job_artifact, :junit_with_corrupted_data, job: build, project: project) } before do allow_any_instance_of(MergeRequest).to receive(:compare_test_reports).and_return(compared_data) visit project_merge_request_path(project, merge_request) end it 'shows the error state' do expect(page).to have_content('Test summary failed loading results') end end def compared_data Ci::CompareTestReportsService.new(project).execute(nil, head_pipeline) end end context 'when test reports have been parsed correctly' do let(:serialized_data) do { status: :parsed, data: TestReportsComparerSerializer .new(project: project) .represent(comparer) } end before do allow_any_instance_of(MergeRequest) .to receive(:has_test_reports?).and_return(true) allow_any_instance_of(MergeRequest) .to receive(:compare_test_reports).and_return(serialized_data) visit project_merge_request_path(project, merge_request) end context 'when a new failures exists' do let(:base_reports) do Gitlab::Ci::Reports::TestReports.new.tap do |reports| reports.get_suite('rspec').add_test_case(create_test_case_rspec_success) reports.get_suite('junit').add_test_case(create_test_case_java_success) end end let(:head_reports) do Gitlab::Ci::Reports::TestReports.new.tap do |reports| reports.get_suite('rspec').add_test_case(create_test_case_rspec_success) reports.get_suite('junit').add_test_case(create_test_case_java_failed) end end it 'shows test reports summary which includes the new failure' do within(".js-reports-container") do click_button 'Expand' expect(page).to have_content('Test summary contained 1 failed test result out of 2 total tests') within(".js-report-section-container") do expect(page).to have_content('rspec found no changed test results out of 1 total test') expect(page).to have_content('junit found 1 failed test result out of 1 total test') expect(page).to have_content('New') expect(page).to have_content('subtractTest') end end end context 'when user clicks the new failure' do it 'shows the test report detail' do within(".js-reports-container") do click_button 'Expand' within(".js-report-section-container") do click_button 'subtractTest' expect(page).to have_content('6.66') expect(page).to have_content(sample_java_failed_message) end end end end end context 'when an existing failure exists' do let(:base_reports) do Gitlab::Ci::Reports::TestReports.new.tap do |reports| reports.get_suite('rspec').add_test_case(create_test_case_rspec_failed) reports.get_suite('junit').add_test_case(create_test_case_java_success) end end let(:head_reports) do Gitlab::Ci::Reports::TestReports.new.tap do |reports| reports.get_suite('rspec').add_test_case(create_test_case_rspec_failed) reports.get_suite('junit').add_test_case(create_test_case_java_success) end end it 'shows test reports summary which includes the existing failure' do within(".js-reports-container") do click_button 'Expand' expect(page).to have_content('Test summary contained 1 failed test result out of 2 total tests') within(".js-report-section-container") do expect(page).to have_content('rspec found 1 failed test result out of 1 total test') expect(page).to have_content('junit found no changed test results out of 1 total test') expect(page).not_to have_content('New') expect(page).to have_content('Test#sum when a is 2 and b is 2 returns summary') end end end context 'when user clicks the existing failure' do it 'shows test report detail of it' do within(".js-reports-container") do click_button 'Expand' within(".js-report-section-container") do click_button 'Test#sum when a is 2 and b is 2 returns summary' expect(page).to have_content('2.22') expect(page).to have_content(sample_rspec_failed_message) end end end end end context 'when a resolved failure exists' do let(:base_reports) do Gitlab::Ci::Reports::TestReports.new.tap do |reports| reports.get_suite('rspec').add_test_case(create_test_case_rspec_success) reports.get_suite('junit').add_test_case(create_test_case_java_failed) end end let(:head_reports) do Gitlab::Ci::Reports::TestReports.new.tap do |reports| reports.get_suite('rspec').add_test_case(create_test_case_rspec_success) reports.get_suite('junit').add_test_case(create_test_case_java_resolved) end end let(:create_test_case_java_resolved) do create_test_case_java_failed.tap do |test_case| test_case.instance_variable_set("@status", Gitlab::Ci::Reports::TestCase::STATUS_SUCCESS) end end it 'shows test reports summary which includes the resolved failure' do within(".js-reports-container") do click_button 'Expand' expect(page).to have_content('Test summary contained 1 fixed test result out of 2 total tests') within(".js-report-section-container") do expect(page).to have_content('rspec found no changed test results out of 1 total test') expect(page).to have_content('junit found 1 fixed test result out of 1 total test') expect(page).to have_content('subtractTest') end end end context 'when user clicks the resolved failure' do it 'shows test report detail of it' do within(".js-reports-container") do click_button 'Expand' within(".js-report-section-container") do click_button 'subtractTest' expect(page).to have_content('6.66') end end end end end def comparer Gitlab::Ci::Reports::TestReportsComparer.new(base_reports, head_reports) end end end end