# frozen_string_literal: true require 'spec_helper' describe Banzai::Filter::CommitReferenceFilter do include FilterSpecHelper let(:project) { create(:project, :public, :repository) } let(:commit) { project.commit } it 'requires project context' do expect { described_class.call('') }.to raise_error(ArgumentError, /:project/) end %w(pre code a style).each do |elem| it "ignores valid references contained inside '#{elem}' element" do exp = act = "<#{elem}>Commit #{commit.id}" expect(reference_filter(act).to_html).to eq exp end end context 'internal reference' do let(:reference) { commit.id } # Let's test a variety of commit SHA sizes just to be paranoid [7, 8, 12, 18, 20, 32, 40].each do |size| it "links to a valid reference of #{size} characters" do doc = reference_filter("See #{reference[0...size]}") expect(doc.css('a').first.text).to eq commit.short_id expect(doc.css('a').first.attr('href')) .to eq urls.project_commit_url(project, reference) end end it 'always uses the short ID as the link text' do doc = reference_filter("See #{commit.id}") expect(doc.text).to eq "See #{commit.short_id}" doc = reference_filter("See #{commit.id[0...7]}") expect(doc.text).to eq "See #{commit.short_id}" end it 'links with adjacent text' do doc = reference_filter("See (#{reference}.)") expect(doc.to_html).to match(%r{\(#{commit.short_id}\.\)}) end it 'ignores invalid commit IDs' do invalid = invalidate_reference(reference) exp = act = "See #{invalid}" expect(reference_filter(act).to_html).to eq exp end it 'includes a title attribute' do doc = reference_filter("See #{reference}") expect(doc.css('a').first.attr('title')).to eq commit.title end it 'escapes the title attribute' do allow_any_instance_of(Commit).to receive(:title).and_return(%{">whatever#{commit.reference_link_text(project)}\.\)}) end it 'ignores invalid commit IDs on the referenced project' do act = "Committed #{invalidate_reference(reference)}" expect(reference_filter(act).to_html).to match(%r{#{Regexp.escape(invalidate_reference(reference))}}) end end context 'URL reference for a commit patch' do let(:namespace) { create(:namespace) } let(:project2) { create(:project, :public, :repository, namespace: namespace) } let(:commit) { project2.commit } let(:link) { urls.project_commit_url(project2, commit.id) } let(:extension) { '.patch' } let(:reference) { link + extension } it 'links to a valid reference' do doc = reference_filter("See #{reference}") expect(doc.css('a').first.attr('href')) .to eq reference end it 'has valid text' do doc = reference_filter("See #{reference}") expect(doc.text).to eq("See #{commit.reference_link_text(project)} (patch)") end it 'does not link to patch when extension match is after the path' do invalidate_commit_reference = reference_filter("#{link}/builds.patch") doc = reference_filter("See (#{invalidate_commit_reference})") expect(doc.css('a').first.attr('href')).to eq "#{link}/builds" expect(doc.text).to eq("See (#{commit.reference_link_text(project)} (builds).patch)") end end context 'group context' do let(:context) { { project: nil, group: create(:group) } } it 'ignores internal references' do exp = act = "See #{commit.id}" expect(reference_filter(act, context).to_html).to eq exp end it 'links to a valid reference' do act = "See #{project.full_path}@#{commit.id}" expect(reference_filter(act, context).css('a').first.text).to eql("#{project.full_path}@#{commit.short_id}") end end end