require 'spec_helper' describe Banzai::Filter::IssueReferenceFilter, lib: true do include FilterSpecHelper def helper IssuesHelper end let(:project) { create(:empty_project, :public) } let(:issue) { create(:issue, project: project) } it 'requires project context' do expect { described_class.call('') }.to raise_error(ArgumentError, /:project/) end %w(pre code a style).each do |elem| it "ignores valid references contained inside '#{elem}' element" do exp = act = "<#{elem}>Issue #{issue.to_reference}" expect(reference_filter(act).to_html).to eq exp end end context 'internal reference' do let(:reference) { issue.to_reference } it 'ignores valid references when using non-default tracker' do expect_any_instance_of(described_class).to receive(:find_object). with(project, issue.iid). and_return(nil) exp = act = "Issue #{reference}" expect(reference_filter(act).to_html).to eq exp end it 'links to a valid reference' do doc = reference_filter("Fixed #{reference}") expect(doc.css('a').first.attr('href')). to eq helper.url_for_issue(issue.iid, project) end it 'links with adjacent text' do doc = reference_filter("Fixed (#{reference}.)") expect(doc.to_html).to match(/\(#{Regexp.escape(reference)}<\/a>\.\)/) end it 'ignores invalid issue IDs' do invalid = invalidate_reference(reference) exp = act = "Fixed #{invalid}" expect(reference_filter(act).to_html).to eq exp end it 'includes a title attribute' do doc = reference_filter("Issue #{reference}") expect(doc.css('a').first.attr('title')).to eq issue.title end it 'escapes the title attribute' do issue.update_attribute(:title, %{">whatever") link = doc.css('a').first.attr('href') expect(link).to eq(href) end end context 'cross-project reference' do let(:namespace) { create(:namespace, name: 'cross-reference') } let(:project2) { create(:empty_project, :public, namespace: namespace) } let(:issue) { create(:issue, project: project2) } let(:reference) { issue.to_reference(project) } it 'ignores valid references when cross-reference project uses external tracker' do expect_any_instance_of(described_class).to receive(:find_object). with(project2, issue.iid). and_return(nil) exp = act = "Issue #{reference}" expect(reference_filter(act).to_html).to eq exp end it 'links to a valid reference' do doc = reference_filter("See #{reference}") expect(doc.css('a').first.attr('href')). to eq helper.url_for_issue(issue.iid, project2) end it 'links with adjacent text' do doc = reference_filter("Fixed (#{reference}.)") expect(doc.to_html).to match(/\(#{Regexp.escape(reference)}<\/a>\.\)/) end it 'ignores invalid issue IDs on the referenced project' do exp = act = "Fixed #{invalidate_reference(reference)}" expect(reference_filter(act).to_html).to eq exp end it 'ignores out-of-bounds issue IDs on the referenced project' do exp = act = "Fixed ##{Gitlab::Database::MAX_INT_VALUE + 1}" expect(reference_filter(act).to_html).to eq exp end end context 'cross-project URL reference' do let(:namespace) { create(:namespace, name: 'cross-reference') } let(:project2) { create(:empty_project, :public, namespace: namespace) } let(:issue) { create(:issue, project: project2) } let(:reference) { helper.url_for_issue(issue.iid, project2) + "#note_123" } it 'links to a valid reference' do doc = reference_filter("See #{reference}") expect(doc.css('a').first.attr('href')). to eq reference end it 'links with adjacent text' do doc = reference_filter("Fixed (#{reference}.)") expect(doc.to_html).to match(/\(#{Regexp.escape(issue.to_reference(project))} \(comment 123\)<\/a>\.\)/) end end context 'cross-project reference in link href' do let(:namespace) { create(:namespace, name: 'cross-reference') } let(:project2) { create(:empty_project, :public, namespace: namespace) } let(:issue) { create(:issue, project: project2) } let(:reference) { %Q{Reference} } it 'links to a valid reference' do doc = reference_filter("See #{reference}") expect(doc.css('a').first.attr('href')). to eq helper.url_for_issue(issue.iid, project2) end it 'links with adjacent text' do doc = reference_filter("Fixed (#{reference}.)") expect(doc.to_html).to match(/\(Reference<\/a>\.\)/) end end context 'cross-project URL in link href' do let(:namespace) { create(:namespace, name: 'cross-reference') } let(:project2) { create(:empty_project, :public, namespace: namespace) } let(:issue) { create(:issue, project: project2) } let(:reference) { %Q{Reference} } it 'links to a valid reference' do doc = reference_filter("See #{reference}") expect(doc.css('a').first.attr('href')). to eq helper.url_for_issue(issue.iid, project2) + "#note_123" end it 'links with adjacent text' do doc = reference_filter("Fixed (#{reference}.)") expect(doc.to_html).to match(/\(Reference<\/a>\.\)/) end end context 'referencing external issues' do let(:project) { create(:redmine_project) } it 'renders internal issue IDs as external issue links' do doc = reference_filter('#1') link = doc.css('a').first expect(link.attr('data-reference-type')).to eq('external_issue') expect(link.attr('title')).to eq('Issue in Redmine') expect(link.attr('data-external-issue')).to eq('1') end end describe '#issues_per_Project' do context 'using an internal issue tracker' do it 'returns a Hash containing the issues per project' do doc = Nokogiri::HTML.fragment('') filter = described_class.new(doc, project: project) expect(filter).to receive(:projects_per_reference). and_return({ project.path_with_namespace => project }) expect(filter).to receive(:references_per_project). and_return({ project.path_with_namespace => Set.new([issue.iid]) }) expect(filter.issues_per_project). to eq({ project => { issue.iid => issue } }) end end context 'using an external issue tracker' do it 'returns a Hash containing the issues per project' do doc = Nokogiri::HTML.fragment('') filter = described_class.new(doc, project: project) expect(project).to receive(:default_issues_tracker?).and_return(false) expect(filter).to receive(:projects_per_reference). and_return({ project.path_with_namespace => project }) expect(filter).to receive(:references_per_project). and_return({ project.path_with_namespace => Set.new([1]) }) expect(filter.issues_per_project[project][1]). to be_an_instance_of(ExternalIssue) end end end end