require 'spec_helper' describe Banzai::Filter::MergeRequestReferenceFilter do include FilterSpecHelper let(:project) { create(:project, :public) } let(:merge) { create(:merge_request, source_project: project) } it 'requires project context' do expect { described_class.call('') }.to raise_error(ArgumentError, /:project/) end %w(pre code a style).each do |elem| it "ignores valid references contained inside '#{elem}' element" do exp = act = "<#{elem}>Merge #{merge.to_reference}" expect(reference_filter(act).to_html).to eq exp end end describe 'performance' do let(:another_merge) { create(:merge_request, source_project: project, source_branch: 'fix') } it 'does not have a N+1 query problem' do single_reference = "Merge request #{merge.to_reference}" multiple_references = "Merge requests #{merge.to_reference} and #{another_merge.to_reference}" control_count = ActiveRecord::QueryRecorder.new { reference_filter(single_reference).to_html }.count expect { reference_filter(multiple_references).to_html }.not_to exceed_query_limit(control_count) end end context 'internal reference' do let(:reference) { merge.to_reference } it 'links to a valid reference' do doc = reference_filter("See #{reference}") expect(doc.css('a').first.attr('href')).to eq urls .project_merge_request_url(project, merge) end it 'links with adjacent text' do doc = reference_filter("Merge (#{reference}.)") expect(doc.to_html).to match(%r{\(#{Regexp.escape(reference)}\.\)}) end it 'ignores invalid merge IDs' do exp = act = "Merge #{invalidate_reference(reference)}" expect(reference_filter(act).to_html).to eq exp end it 'ignores out-of-bounds merge request IDs on the referenced project' do exp = act = "Merge !#{Gitlab::Database::MAX_INT_VALUE + 1}" expect(reference_filter(act).to_html).to eq exp end it 'includes a title attribute' do doc = reference_filter("Merge #{reference}") expect(doc.css('a').first.attr('title')).to eq merge.title end it 'escapes the title attribute' do merge.update_attribute(:title, %{">whatever#{Regexp.escape(merge.to_reference(project))} \(diffs, comment 123\)\.\)}) end end context 'group context' do it 'links to a valid reference' do reference = "#{project.full_path}!#{merge.iid}" result = reference_filter("See #{reference}", { project: nil, group: create(:group) } ) expect(result.css('a').first.attr('href')).to eq(urls.project_merge_request_url(project, merge)) end end end