# frozen_string_literal: true require 'spec_helper' RSpec.describe Gitlab::Email::Handler::CreateMergeRequestHandler do include_context :email_shared_context let!(:user) do create( :user, email: 'jake@adventuretime.ooo', incoming_email_token: 'auth_token' ) end let!(:project) { create(:project, :public, :repository, namespace: namespace, path: 'gitlabhq') } let(:namespace) { create(:namespace, path: 'gitlabhq') } let(:email_raw) { email_fixture('emails/valid_new_merge_request.eml') } it_behaves_like :reply_processing_shared_examples before do stub_incoming_email_setting(enabled: true, address: "incoming+%{key}@appmail.adventuretime.ooo") stub_config_setting(host: 'localhost') end after do TestEnv.clean_test_path end context "when email key" do let(:mail) { Mail::Message.new(email_raw) } it "matches the new format" do handler = described_class.new(mail, "gitlabhq-gitlabhq-#{project.project_id}-#{user.incoming_email_token}-merge-request") expect(handler.instance_variable_get(:@project_id)).to eq project.project_id expect(handler.instance_variable_get(:@project_slug)).to eq project.full_path_slug expect(handler.instance_variable_get(:@incoming_email_token)).to eq user.incoming_email_token expect(handler.can_handle?).to be_truthy end it "matches the legacy format" do handler = described_class.new(mail, "h5bp/html5-boilerplate+merge-request+#{user.incoming_email_token}") expect(handler.instance_variable_get(:@project_path)).to eq 'h5bp/html5-boilerplate' expect(handler.instance_variable_get(:@incoming_email_token)).to eq user.incoming_email_token expect(handler.can_handle?).to be_truthy end it "doesn't match either format" do handler = described_class.new(mail, "h5bp-html5-boilerplate+merge-request") expect(handler.can_handle?).to be_falsey end end context "as a non-developer" do before do project.add_guest(user) end it "raises UserNotAuthorizedError if the user is not a member" do expect { receiver.execute }.to raise_error(Gitlab::Email::UserNotAuthorizedError) end end context "as a developer" do before do project.add_developer(user) end context "when everything is fine" do shared_examples "a new merge request" do it "creates a new merge request" do expect { receiver.execute }.to change { project.merge_requests.count }.by(1) merge_request = project.merge_requests.last expect(merge_request.author).to eq(user) expect(merge_request.source_branch).to eq('feature') expect(merge_request.title).to eq('Feature added') expect(merge_request.description).to eq('Merge request description') expect(merge_request.target_branch).to eq(project.default_branch) end end it_behaves_like "a new merge request" context "creates a new merge request with legacy email address" do let(:email_raw) { fixture_file('emails/valid_new_merge_request_legacy.eml') } it_behaves_like "a new merge request" end end context "something is wrong" do context "when the merge request could not be saved" do before do allow_next_instance_of(MergeRequest) do |instance| allow(instance).to receive(:save).and_return(false) end end it "raises an InvalidMergeRequestError" do expect { receiver.execute }.to raise_error(Gitlab::Email::InvalidMergeRequestError) end end context "when we can't find the incoming_email_token" do let(:email_raw) { email_fixture("emails/wrong_merge_request_incoming_email_token.eml") } it "raises an UserNotFoundError" do expect { receiver.execute }.to raise_error(Gitlab::Email::UserNotFoundError) end end context "when the subject is blank" do let(:email_raw) { email_fixture("emails/valid_new_merge_request_no_subject.eml") } it "raises an InvalidMergeRequestError" do expect { receiver.execute }.to raise_error(Gitlab::Email::InvalidMergeRequestError) end end context "when the message body is blank" do let(:email_raw) { email_fixture("emails/valid_new_merge_request_no_description.eml") } it "creates a new merge request with description set from the last commit" do expect { receiver.execute }.to change { project.merge_requests.count }.by(1) merge_request = project.merge_requests.last expect(merge_request.description).to eq('Signed-off-by: Dmitriy Zaporozhets ') end end end context 'when the email contains patch attachments' do let(:email_raw) { email_fixture("emails/valid_merge_request_with_patch.eml") } it 'creates the source branch and applies the patches' do receiver.execute branch = project.repository.find_branch('new-branch-with-a-patch') expect(branch).not_to be_nil expect(branch.dereferenced_target.message).to include('A commit from a patch') end it 'creates the merge request' do expect { receiver.execute } .to change { project.merge_requests.where(source_branch: 'new-branch-with-a-patch').size }.by(1) end it 'does not mention the patches in the created merge request' do receiver.execute merge_request = project.merge_requests.find_by!(source_branch: 'new-branch-with-a-patch') expect(merge_request.description).not_to include('0001-A-commit-from-a-patch.patch') end context 'when the patch could not be applied' do let(:email_raw) { email_fixture("emails/merge_request_with_conflicting_patch.eml") } it 'raises an error' do expect { receiver.execute }.to raise_error(Gitlab::Email::InvalidAttachment) end end context 'when specifying the target branch using quick actions' do let(:email_raw) { email_fixture('emails/merge_request_with_patch_and_target_branch.eml') } it 'creates the merge request with the correct target branch' do receiver.execute merge_request = project.merge_requests.find_by!(source_branch: 'new-branch-with-a-patch') expect(merge_request.target_branch).to eq('with-codeowners') end it 'based the merge request of the target_branch' do receiver.execute merge_request = project.merge_requests.find_by!(source_branch: 'new-branch-with-a-patch') expect(merge_request.diff_base_commit).to eq(project.repository.commit('with-codeowners')) end end end end describe '#patch_attachments' do let(:email_raw) { email_fixture('emails/merge_request_multiple_patches.eml') } let(:mail) { Mail::Message.new(email_raw) } subject(:handler) { described_class.new(mail, mail_key) } it 'orders attachments ending in `.patch` by name' do expected_filenames = ["0001-A-commit-from-a-patch.patch", "0002-This-does-not-apply-to-the-feature-branch.patch"] attachments = handler.__send__(:patch_attachments).map(&:filename) expect(attachments).to eq(expected_filenames) end end def email_fixture(path) fixture_file(path).gsub('project_id', project.project_id.to_s) end end