require 'spec_helper' describe ProcessCommitWorker do let(:worker) { described_class.new } let(:user) { create(:user) } let(:project) { create(:project, :public, :repository) } let(:issue) { create(:issue, project: project, author: user) } let(:commit) { project.commit } describe '#perform' do it 'does not process the commit when the project does not exist' do expect(worker).not_to receive(:close_issues) worker.perform(-1, user.id, commit.to_hash) end it 'does not process the commit when the user does not exist' do expect(worker).not_to receive(:close_issues) worker.perform(project.id, -1, commit.to_hash) end it 'processes the commit message' do expect(worker).to receive(:process_commit_message).and_call_original worker.perform(project.id, user.id, commit.to_hash) end it 'updates the issue metrics' do expect(worker).to receive(:update_issue_metrics).and_call_original worker.perform(project.id, user.id, commit.to_hash) end context 'when commit already exists in upstream project' do let(:forked) { create(:project, :public, :repository) } it 'does not process commit message' do create(:forked_project_link, forked_to_project: forked, forked_from_project: project) expect(worker).not_to receive(:process_commit_message) worker.perform(forked.id, user.id, forked.commit.to_hash) end end end describe '#process_commit_message' do context 'when pushing to the default branch' do before do allow(commit).to receive(:safe_message).and_return("Closes #{issue.to_reference}") end it 'closes issues that should be closed per the commit message' do expect(worker).to receive(:close_issues).with(project, user, user, commit, [issue]) worker.process_commit_message(project, commit, user, user, true) end it 'creates cross references' do expect(commit).to receive(:create_cross_references!).with(user, [issue]) worker.process_commit_message(project, commit, user, user, true) end end context 'when pushing to a non-default branch' do it 'does not close any issues' do allow(commit).to receive(:safe_message).and_return("Closes #{issue.to_reference}") expect(worker).not_to receive(:close_issues) worker.process_commit_message(project, commit, user, user, false) end it 'does not create cross references' do expect(commit).to receive(:create_cross_references!).with(user, []) worker.process_commit_message(project, commit, user, user, false) end end context 'when commit is a merge request merge commit to the default branch' do let(:merge_request) do create(:merge_request, description: "Closes #{issue.to_reference}", source_branch: 'feature-merged', target_branch: 'master', source_project: project) end let(:commit) do project.repository.create_branch('feature-merged', 'feature') MergeRequests::MergeService .new(project, merge_request.author) .execute(merge_request) merge_request.reload.merge_commit end it 'does not close any issues from the commit message' do expect(worker).not_to receive(:close_issues) worker.process_commit_message(project, commit, user, user, true) end it 'still creates cross references' do expect(commit).to receive(:create_cross_references!).with(user, []) worker.process_commit_message(project, commit, user, user, true) end end end describe '#close_issues' do context 'when the user can update the issues' do it 'closes the issues' do worker.close_issues(project, user, user, commit, [issue]) issue.reload expect(issue.closed?).to eq(true) end end context 'when the user can not update the issues' do it 'does not close the issues' do other_user = create(:user) worker.close_issues(project, other_user, other_user, commit, [issue]) issue.reload expect(issue.closed?).to eq(false) end end end describe '#update_issue_metrics' do it 'updates any existing issue metrics' do allow(commit).to receive(:safe_message).and_return("Closes #{issue.to_reference}") worker.update_issue_metrics(commit, user) metric = Issue::Metrics.first expect(metric.first_mentioned_in_commit_at).to eq(commit.committed_date) end it "doesn't execute any queries with false conditions" do allow(commit).to receive(:safe_message).and_return("Lorem Ipsum") expect { worker.update_issue_metrics(commit, user) } .not_to make_queries_matching(/WHERE (?:1=0|0=1)/) end end describe '#build_commit' do it 'returns a Commit' do commit = worker.build_commit(project, id: '123') expect(commit).to be_an_instance_of(Commit) end it 'parses date strings into Time instances' do commit = worker.build_commit(project, id: '123', authored_date: Time.now.to_s) expect(commit.authored_date).to be_an_instance_of(Time) end end end