summaryrefslogtreecommitdiff
path: root/qa/qa/specs/features/api/3_create/gitaly/distributed_reads_spec.rb
blob: 9bf3474ba5ae43f32e93005f45cfd378440033b3 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
# frozen_string_literal: true

require 'parallel'

module QA
  RSpec.describe 'Create' do
    context 'Gitaly' do
      # Issue to track removal of feature flag: https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/602
      describe 'Distributed reads', :orchestrated, :gitaly_cluster, :skip_live_env, :requires_admin do
        let(:number_of_reads_per_loop) { 9 }
        let(:praefect_manager) { Service::PraefectManager.new }
        let(:project) do
          Resource::Project.fabricate! do |project|
            project.name = "gitaly_cluster"
            project.initialize_with_readme = true
          end
        end

        before do
          Runtime::Feature.enable(:gitaly_distributed_reads)
          praefect_manager.wait_for_replication(project.id)
        end

        after do
          Runtime::Feature.disable(:gitaly_distributed_reads)
        end

        it 'reads from each node', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/979' do
          pre_read_data = praefect_manager.query_read_distribution

          wait_for_reads_to_increase(project, number_of_reads_per_loop, pre_read_data)

          aggregate_failures "each gitaly node" do
            praefect_manager.query_read_distribution.each_with_index do |data, index|
              pre_read_count = praefect_manager.value_for_node(pre_read_data, data[:node])
              QA::Runtime::Logger.debug("Node: #{data[:node]}; before: #{pre_read_count}; now: #{data[:value]}")
              expect(data[:value]).to be > pre_read_count,
                "Read counts did not differ for node #{data[:node]}"
            end
          end
        end

        context 'when a node is unhealthy' do
          before do
            praefect_manager.stop_secondary_node
            praefect_manager.wait_for_secondary_node_health_check_failure
          end

          after do
            # Leave the cluster in a suitable state for subsequent tests
            praefect_manager.start_secondary_node
            praefect_manager.wait_for_health_check_all_nodes
            praefect_manager.wait_for_reliable_connection
          end

          it 'does not read from the unhealthy node', testcase: 'https://gitlab.com/gitlab-org/quality/testcases/-/issues/980' do
            pre_read_data = praefect_manager.query_read_distribution

            read_from_project(project, number_of_reads_per_loop * 10)

            praefect_manager.wait_for_read_count_change(pre_read_data)

            post_read_data = praefect_manager.query_read_distribution

            aggregate_failures "each gitaly node" do
              expect(praefect_manager.value_for_node(post_read_data, 'gitaly1')).to be > praefect_manager.value_for_node(pre_read_data, 'gitaly1')
              expect(praefect_manager.value_for_node(post_read_data, 'gitaly2')).to eq praefect_manager.value_for_node(pre_read_data, 'gitaly2')
              expect(praefect_manager.value_for_node(post_read_data, 'gitaly3')).to be > praefect_manager.value_for_node(pre_read_data, 'gitaly3')
            end
          end
        end

        def read_from_project(project, number_of_reads)
          QA::Runtime::Logger.info('Reading from the repository')
          Parallel.each((1..number_of_reads)) do
            Git::Repository.perform do |repository|
              repository.uri = project.repository_http_location.uri
              repository.use_default_credentials
              repository.clone
            end
          end
        end

        def wait_for_reads_to_increase(project, number_of_reads, pre_read_data)
          diff_found = pre_read_data

          Support::Waiter.wait_until(sleep_interval: 5, raise_on_failure: false) do
            read_from_project(project, number_of_reads)

            praefect_manager.query_read_distribution.each_with_index do |data, index|
              diff_found[index] = {} unless diff_found[index]
              diff_found[index][:diff] = true if data[:value] > praefect_manager.value_for_node(pre_read_data, data[:node])
            end
            diff_found.all? { |node| node.key?(:diff) && node[:diff] }
          end
        end
      end
    end
  end
end