blob: c2ba6c2a206820aa44718edc88f79869b0bc7ae3 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
|
# frozen_string_literal: true
module RuboCop
module Cop
module Performance
class ARExistsAndPresentBlank < RuboCop::Cop::Base
def message_present(ivar)
"Avoid `#{ivar}.present?`, because it will generate database query 'Select TABLE.*' which is expensive. "\
"Suggest to use `#{ivar}.any?` to replace `#{ivar}.present?`"
end
def message_blank(ivar)
"Avoid `#{ivar}.blank?`, because it will generate database query 'Select TABLE.*' which is expensive. "\
"Suggest to use `#{ivar}.empty?` to replace `#{ivar}.blank?`"
end
def_node_matcher :exists_match, <<~PATTERN
(send (ivar $_) :exists?)
PATTERN
def_node_matcher :present_match, <<~PATTERN
(send (ivar $_) :present?)
PATTERN
def_node_matcher :blank_match, <<~PATTERN
(send (ivar $_) :blank?)
PATTERN
def file_name(node)
node.location.expression.source_buffer.name
end
def in_haml_file?(node)
file_name(node).end_with?('.haml.rb')
end
def on_send(node)
return unless in_haml_file?(node)
ivar_present = present_match(node)
ivar_blank = blank_match(node)
return unless ivar_present || ivar_blank
node.each_ancestor(:begin) do |begin_node|
begin_node.each_descendant do |n|
ivar_exists = exists_match(n)
next unless ivar_exists
add_offense(node, message: message_present(ivar_exists)) if ivar_exists == ivar_present
add_offense(node, message: message_blank(ivar_exists)) if ivar_exists == ivar_blank
end
end
end
end
end
end
end
|
