summaryrefslogtreecommitdiff
path: root/scripts/lint-rugged
blob: d0c2c544c4788054192be8d0afbe4cf7b3e13ce8 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
#!/usr/bin/env ruby

ALLOWED = [
  # Can be fixed once Rugged is no longer used in production. Doesn't make Rugged calls.
  'config/initializers/8_metrics.rb',

  # Can be deleted once wiki's are fully (mandatory) migrated
  'config/initializers/gollum.rb',

  # Needs to be migrated, https://gitlab.com/gitlab-org/gitaly/issues/953
  'lib/gitlab/bare_repository_import/repository.rb',

  # Needs to be migrated, https://gitlab.com/gitlab-org/gitaly/issues/954
  'lib/tasks/gitlab/cleanup.rake',

  # The only place where Rugged code is still allowed in production
  'lib/gitlab/git/',

  # Needed to avoid using the git binary to validate a branch name
  'lib/gitlab/git_ref_validator.rb'
].freeze

rugged_lines = IO.popen(%w[git grep -i -n rugged -- app config lib], &:read).lines
rugged_lines = rugged_lines.select { |l| /^[^:]*\.rb:/ =~ l }
rugged_lines = rugged_lines.reject { |l| l.start_with?(*ALLOWED) }
rugged_lines = rugged_lines.reject do |line|
  code, _comment = line.split('# ', 2)
  code !~ /rugged/i
end

exit if rugged_lines.empty?

puts "Using Rugged is only allowed in test and #{ALLOWED}\n\n"

puts rugged_lines

exit(false)