summaryrefslogtreecommitdiff
path: root/spec/controllers/groups/releases_controller_spec.rb
blob: 582a77b1c509e5a9952879469979d215024dee61 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe Groups::ReleasesController do
  let(:group) { create(:group) }
  let!(:project)         { create(:project, :repository, :public, namespace: group) }
  let!(:private_project) { create(:project, :repository, :private, namespace: group) }
  let(:guest) { create(:user) }
  let!(:release_1)       { create(:release, project: project, tag: 'v1', released_at: Time.zone.parse('2020-02-15')) }
  let!(:release_2)       { create(:release, project: project, tag: 'v2', released_at: Time.zone.parse('2020-02-20')) }
  let!(:private_release_1)       { create(:release, project: private_project, tag: 'p1', released_at: Time.zone.parse('2020-03-01')) }
  let!(:private_release_2)       { create(:release, project: private_project, tag: 'p2', released_at: Time.zone.parse('2020-03-05')) }

  before do
    group.add_guest(guest)
  end

  describe 'GET #index' do
    context 'as json' do
      let(:format) { :json }

      subject { get :index, params: { group_id: group }, format: format }

      context 'json_response' do
        before do
          subject
        end

        it 'returns an application/json content_type' do
          expect(response.media_type).to eq 'application/json'
        end

        it 'returns OK' do
          expect(response).to have_gitlab_http_status(:ok)
        end
      end

      context 'the user is not authorized' do
        before do
          subject
        end

        it 'does not return any releases' do
          expect(json_response.map {|r| r['tag'] } ).to be_empty
        end

        it 'returns OK' do
          expect(response).to have_gitlab_http_status(:ok)
        end
      end

      context 'the user is authorized' do
        it "returns all group's public and private project's releases as JSON, ordered by released_at" do
          sign_in(guest)

          subject

          expect(json_response.map {|r| r['tag'] } ).to match_array(%w(p2 p1 v2 v1))
        end
      end

      context 'N+1 queries' do
        it 'avoids N+1 database queries' do
          control_count = ActiveRecord::QueryRecorder.new { subject }.count

          create_list(:release, 5, project: project)
          create_list(:release, 5, project: private_project)

          expect { subject }.not_to exceed_query_limit(control_count)
        end
      end
    end
  end
end