1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
|
# frozen_string_literal: true
require 'spec_helper'
describe Groups::RunnersController do
let(:user) { create(:user) }
let(:group) { create(:group) }
let(:runner) { create(:ci_runner, :group, groups: [group]) }
let(:params) { { group_id: group, id: runner } }
before do
sign_in(user)
end
describe '#show' do
context 'when user is owner' do
before do
group.add_owner(user)
end
it 'renders show with 200 status code' do
get :show, params: { group_id: group, id: runner }
expect(response).to have_gitlab_http_status(200)
expect(response).to render_template(:show)
end
end
context 'when user is not owner' do
before do
group.add_maintainer(user)
end
it 'renders a 404' do
get :show, params: { group_id: group, id: runner }
expect(response).to have_gitlab_http_status(404)
end
end
end
describe '#edit' do
context 'when user is owner' do
before do
group.add_owner(user)
end
it 'renders show with 200 status code' do
get :edit, params: { group_id: group, id: runner }
expect(response).to have_gitlab_http_status(200)
expect(response).to render_template(:edit)
end
end
context 'when user is not owner' do
before do
group.add_maintainer(user)
end
it 'renders a 404' do
get :edit, params: { group_id: group, id: runner }
expect(response).to have_gitlab_http_status(404)
end
end
end
describe '#update' do
context 'when user is an owner' do
before do
group.add_owner(user)
end
it 'updates the runner, ticks the queue, and redirects' do
new_desc = runner.description.swapcase
expect do
post :update, params: params.merge(runner: { description: new_desc } )
end.to change { runner.ensure_runner_queue_value }
expect(response).to have_gitlab_http_status(302)
expect(runner.reload.description).to eq(new_desc)
end
end
context 'when user is not an owner' do
before do
group.add_maintainer(user)
end
it 'rejects the update and responds 404' do
old_desc = runner.description
expect do
post :update, params: params.merge(runner: { description: old_desc.swapcase } )
end.not_to change { runner.ensure_runner_queue_value }
expect(response).to have_gitlab_http_status(404)
expect(runner.reload.description).to eq(old_desc)
end
end
end
describe '#destroy' do
context 'when user is an owner' do
before do
group.add_owner(user)
end
it 'destroys the runner and redirects' do
delete :destroy, params: params
expect(response).to have_gitlab_http_status(302)
expect(Ci::Runner.find_by(id: runner.id)).to be_nil
end
end
context 'when user is not an owner' do
before do
group.add_maintainer(user)
end
it 'responds 404 and does not destroy the runner' do
delete :destroy, params: params
expect(response).to have_gitlab_http_status(404)
expect(Ci::Runner.find_by(id: runner.id)).to be_present
end
end
end
describe '#resume' do
context 'when user is an owner' do
before do
group.add_owner(user)
end
it 'marks the runner as active, ticks the queue, and redirects' do
runner.update(active: false)
expect do
post :resume, params: params
end.to change { runner.ensure_runner_queue_value }
expect(response).to have_gitlab_http_status(302)
expect(runner.reload.active).to eq(true)
end
end
context 'when user is not an owner' do
before do
group.add_maintainer(user)
end
it 'responds 404 and does not activate the runner' do
runner.update(active: false)
expect do
post :resume, params: params
end.not_to change { runner.ensure_runner_queue_value }
expect(response).to have_gitlab_http_status(404)
expect(runner.reload.active).to eq(false)
end
end
end
describe '#pause' do
context 'when user is an owner' do
before do
group.add_owner(user)
end
it 'marks the runner as inactive, ticks the queue, and redirects' do
runner.update(active: true)
expect do
post :pause, params: params
end.to change { runner.ensure_runner_queue_value }
expect(response).to have_gitlab_http_status(302)
expect(runner.reload.active).to eq(false)
end
end
context 'when user is not an owner' do
before do
group.add_maintainer(user)
end
it 'responds 404 and does not update the runner or queue' do
runner.update(active: true)
expect do
post :pause, params: params
end.not_to change { runner.ensure_runner_queue_value }
expect(response).to have_gitlab_http_status(404)
expect(runner.reload.active).to eq(true)
end
end
end
end
|
