summaryrefslogtreecommitdiff
path: root/spec/controllers/projects/milestones_controller_spec.rb
blob: 00cf464ec5bcf25890efe0036e74bd375e93921a (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
require 'spec_helper'

describe Projects::MilestonesController do
  let(:project) { create(:project) }
  let(:user)    { create(:user) }
  let(:milestone) { create(:milestone, project: project) }
  let(:issue) { create(:issue, project: project, milestone: milestone) }
  let!(:label) { create(:label, project: project, title: 'Issue Label', issues: [issue]) }
  let!(:merge_request) { create(:merge_request, source_project: project, target_project: project, milestone: milestone) }
  let(:milestone_path) { namespace_project_milestone_path }

  before do
    sign_in(user)
    project.add_master(user)
    controller.instance_variable_set(:@project, project)
  end

  it_behaves_like 'milestone tabs'

  describe "#show" do
    render_views

    def view_milestone
      get :show, namespace_id: project.namespace.id, project_id: project.id, id: milestone.iid
    end

    it 'shows milestone page' do
      view_milestone

      expect(response).to have_gitlab_http_status(200)
    end
  end

  describe "#index" do
    context "as html" do
      before do
        get :index, namespace_id: project.namespace.id, project_id: project.id
      end

      it "queries only projects milestones" do
        milestones = assigns(:milestones)

        expect(milestones.count).to eq(1)
        expect(milestones.where(project_id: nil)).to be_empty
      end
    end

    context "as json" do
      let!(:group) { create(:group, :public) }
      let!(:group_milestone) { create(:milestone, group: group) }
      let!(:group_member) { create(:group_member, group: group, user: user) }

      before do
        project.update(namespace: group)
        get :index, namespace_id: project.namespace.id, project_id: project.id, format: :json
      end

      it "queries projects milestones and groups milestones" do
        milestones = assigns(:milestones)

        expect(milestones.count).to eq(2)
        expect(milestones.where(project_id: nil).first).to eq(group_milestone)
        expect(milestones.where(group_id: nil).first).to eq(milestone)
      end
    end
  end

  describe "#destroy" do
    it "removes milestone" do
      expect(issue.milestone_id).to eq(milestone.id)

      delete :destroy, namespace_id: project.namespace.id, project_id: project.id, id: milestone.iid, format: :js
      expect(response).to be_success

      expect(Event.recent.first.action).to eq(Event::DESTROYED)

      expect { Milestone.find(milestone.id) }.to raise_exception(ActiveRecord::RecordNotFound)
      issue.reload
      expect(issue.milestone_id).to eq(nil)

      merge_request.reload
      expect(merge_request.milestone_id).to eq(nil)

      # Check system note left for milestone removal
      last_note = project.issues.find(issue.id).notes[-1].note
      expect(last_note).to eq('removed milestone')
    end
  end

  describe '#promote' do
    context 'promotion succeeds' do
      before do
        group = create(:group)
        group.add_developer(user)
        milestone.project.update(namespace: group)
      end

      it 'shows group milestone' do
        post :promote, namespace_id: project.namespace.id, project_id: project.id, id: milestone.iid

        group_milestone = assigns(:milestone)

        expect(response).to redirect_to(group_milestone_path(project.group, group_milestone.iid))
        expect(flash[:notice]).to eq('Milestone has been promoted to group milestone.')
      end
    end

    context 'promotion fails' do
      it 'shows project milestone' do
        post :promote, namespace_id: project.namespace.id, project_id: project.id, id: milestone.iid

        expect(response).to redirect_to(project_milestone_path(project, milestone))
        expect(flash[:alert]).to eq('Promotion failed - Project does not belong to a group.')
      end
    end
  end
end