summaryrefslogtreecommitdiff
path: root/spec/controllers/projects/project_members_controller_spec.rb
blob: fc5f458e79543b3496af06c64b6e6fe380716492 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
require('spec_helper')

describe Projects::ProjectMembersController do
  describe '#apply_import' do
    let(:project) { create(:project) }
    let(:another_project) { create(:project, :private) }
    let(:user) { create(:user) }
    let(:member) { create(:user) }

    before do
      project.team << [user, :master]
      another_project.team << [member, :guest]
      sign_in(user)
    end

    shared_context 'import applied' do
      before do
        post(:apply_import, namespace_id: project.namespace,
                            project_id: project,
                            source_project_id: another_project.id)
      end
    end

    context 'when user can access source project members' do
      before { another_project.team << [user, :guest] }
      include_context 'import applied'

      it 'imports source project members' do
        expect(project.team_members).to include member
        expect(response).to set_flash.to 'Successfully imported'
        expect(response).to redirect_to(
          namespace_project_project_members_path(project.namespace, project)
        )
      end
    end

    context 'when user is not member of a source project' do
      include_context 'import applied'

      it 'does not import team members' do
        expect(project.team_members).not_to include member
      end

      it 'responds with not found' do
        expect(response.status).to eq 404
      end
    end
  end

  describe '#index' do
    context 'when user is member' do
      before do
        project = create(:project, :private)
        member = create(:user)
        project.team << [member, :guest]
        sign_in(member)

        get :index, namespace_id: project.namespace, project_id: project
      end

      it { expect(response.status).to eq(200) }
    end
  end

  describe '#destroy' do
    let(:project) { create(:project, :public) }

    context 'when member is not found' do
      it 'returns 404' do
        delete :destroy, namespace_id: project.namespace,
                         project_id: project,
                         id: 42

        expect(response.status).to eq(404)
      end
    end

    context 'when member is found' do
      let(:user) { create(:user) }
      let(:team_user) { create(:user) }
      let(:member) do
        project.team << [team_user, :developer]
        project.members.find_by(user_id: team_user.id)
      end

      context 'when user does not have enough rights' do
        before do
          project.team << [user, :developer]
          sign_in(user)
        end

        it 'returns 404' do
          delete :destroy, namespace_id: project.namespace,
                           project_id: project,
                           id: member

          expect(response.status).to eq(404)
          expect(project.users).to include team_user
        end
      end

      context 'when user has enough rights' do
        before do
          project.team << [user, :master]
          sign_in(user)
        end

        it '[HTML] removes user from members' do
          delete :destroy, namespace_id: project.namespace,
                           project_id: project,
                           id: member

          expect(response).to redirect_to(
            namespace_project_project_members_path(project.namespace, project)
          )
          expect(project.users).not_to include team_user
        end

        it '[JS] removes user from members' do
          xhr :delete, :destroy, namespace_id: project.namespace,
                                 project_id: project,
                                 id: member

          expect(response).to be_success
          expect(project.users).not_to include team_user
        end
      end
    end
  end

  describe '#leave' do
    let(:project) { create(:project, :public) }
    let(:user) { create(:user) }

    context 'when member is not found' do
      before { sign_in(user) }

      it 'returns 403' do
        delete :leave, namespace_id: project.namespace,
                       project_id: project

        expect(response.status).to eq(403)
      end
    end

    context 'when member is found' do
      context 'and is not an owner' do
        before do
          project.team << [user, :developer]
          sign_in(user)
        end

        it 'removes user from members' do
          delete :leave, namespace_id: project.namespace,
                         project_id: project

          expect(response).to set_flash.to "You left the \"#{project.human_name}\" project."
          expect(response).to redirect_to(dashboard_projects_path)
          expect(project.users).not_to include user
        end
      end

      context 'and is an owner' do
        before do
          project.update(namespace_id: user.namespace_id)
          project.team << [user, :master, user]
          sign_in(user)
        end

        it 'cannot remove himself from the project' do
          delete :leave, namespace_id: project.namespace,
                         project_id: project

          expect(response).to redirect_to(
            namespace_project_path(project.namespace, project)
          )
          expect(response).to set_flash[:alert].to "You can not leave the \"#{project.human_name}\" project. Transfer or delete the project."
          expect(project.users).to include user
        end
      end

      context 'and is a requester' do
        before do
          project.request_access(user)
          sign_in(user)
        end

        it 'removes user from members' do
          delete :leave, namespace_id: project.namespace,
                         project_id: project

          expect(response).to set_flash.to 'Your access request to the project has been withdrawn.'
          expect(response).to redirect_to(dashboard_projects_path)
          expect(project.members.request).to be_empty
          expect(project.users).not_to include user
        end
      end
    end
  end

  describe '#request_access' do
    let(:project) { create(:project, :public) }
    let(:user) { create(:user) }

    before do
      sign_in(user)
    end

    it 'creates a new ProjectMember that is not a team member' do
      post :request_access, namespace_id: project.namespace,
                            project_id: project

      expect(response).to set_flash.to 'Your request for access has been queued for review.'
      expect(response).to redirect_to(
        namespace_project_path(project.namespace, project)
      )
      expect(project.members.request.exists?(user_id: user)).to be_truthy
      expect(project.users).not_to include user
    end
  end

  describe '#approve' do
    let(:project) { create(:project, :public) }

    context 'when member is not found' do
      it 'returns 404' do
        post :approve_access_request, namespace_id: project.namespace,
                                      project_id: project,
                                      id: 42

        expect(response.status).to eq(404)
      end
    end

    context 'when member is found' do
      let(:user) { create(:user) }
      let(:team_requester) { create(:user) }
      let(:member) do
        project.request_access(team_requester)
        project.members.request.find_by(user_id: team_requester.id)
      end

      context 'when user does not have enough rights' do
        before do
          project.team << [user, :developer]
          sign_in(user)
        end

        it 'returns 404' do
          post :approve_access_request, namespace_id: project.namespace,
                                        project_id: project,
                                        id: member

          expect(response.status).to eq(404)
          expect(project.users).not_to include team_requester
        end
      end

      context 'when user has enough rights' do
        before do
          project.team << [user, :master]
          sign_in(user)
        end

        it 'adds user to members' do
          post :approve_access_request, namespace_id: project.namespace,
                                        project_id: project,
                                        id: member

          expect(response).to redirect_to(
            namespace_project_project_members_path(project.namespace, project)
          )
          expect(project.users).to include team_requester
        end
      end
    end
  end
end